public inbox for libabigail@sourceware.org
 help / color / mirror / Atom feed
From: "gprocida+abigail at google dot com" <sourceware-bugzilla@sourceware.org>
To: libabigail@sourceware.org
Subject: [Bug default/26998] abidiff --leaf-changes-only misreports array member changes
Date: Thu, 03 Dec 2020 10:43:20 +0000	[thread overview]
Message-ID: <bug-26998-9487-Zu28sHELuw@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-26998-9487@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=26998

--- Comment #1 from Giuliano Procida <gprocida+abigail at google dot com> ---
Here's another even smaller test case that has similar issues.

$ head -100 small.?.c
==> small.0.c <==
struct buzz {
  int a;
};

struct flexible {
  struct buzz lightyear[0];
};

struct flexible impacted;

==> small.1.c <==
struct buzz {
  long a;
};

struct flexible {
  struct buzz lightyear[0];
};

struct flexible impacted;
$ for x in small.{0,1}.c; do gcc -Wall -Wextra -g -c $x; done
$ for x in small.{0,1}; do abidw $x.o > $x.abi; done
$ abidiff --leaf-changes-only small.?.o
Leaf changes summary: 3 artifacts changed
Changed leaf types summary: 2 leaf types changed
Removed/Changed/Added functions summary: 0 Removed, 0 Changed, 0 Added function
Removed/Changed/Added variables summary: 0 Removed, 1 Changed, 0 Added variable

1 Changed variable:

  [C] 'flexible impacted' was changed at small.1.c:9:1:
    type of variable changed:
      type size hasn't changed
      there are data member changes:
        'buzz flexible::lightyear[]' has *some* difference - please report as a
bug

'struct buzz at small.0.c:1:1' changed:
  type size changed from 32 to 64 (in bits)
  there are data member changes:
    type 'int' of 'buzz::a' changed:
      type name changed from 'int' to 'long int'
      type size changed from 32 to 64 (in bits)

'struct flexible at small.0.c:5:1' changed:
  details were reported earlier
$ diff <(abidiff --leaf-changes-only small.?.o) <(abidiff --leaf-changes-only
small.?.abi)

-- 
You are receiving this mail because:
You are on the CC list for the bug.

  reply	other threads:[~2020-12-03 10:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-02 17:10 [Bug default/26998] New: " gprocida+abigail at google dot com
2020-12-03 10:43 ` gprocida+abigail at google dot com [this message]
2020-12-03 12:45 ` [Bug default/26998] " gprocida+abigail at google dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-26998-9487-Zu28sHELuw@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=libabigail@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).