From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sourceware-bugzilla@sourceware.org>
Received: by sourceware.org (Postfix, from userid 48)
 id 641993898536; Wed,  3 Feb 2021 13:14:16 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 641993898536
From: "dodji at redhat dot com" <sourceware-bugzilla@sourceware.org>
To: libabigail@sourceware.org
Subject: [Bug default/27331] abidiff --leaf-changes-only is blind to bitfield
 offset changes
Date: Wed, 03 Feb 2021 13:14:16 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: libabigail
X-Bugzilla-Component: default
X-Bugzilla-Version: unspecified
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: dodji at redhat dot com
X-Bugzilla-Status: RESOLVED
X-Bugzilla-Resolution: FIXED
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: dodji at redhat dot com
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: bug_status resolution
Message-ID: <bug-27331-9487-Ky0ibKFMee@http.sourceware.org/bugzilla/>
In-Reply-To: <bug-27331-9487@http.sourceware.org/bugzilla/>
References: <bug-27331-9487@http.sourceware.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: libabigail@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Mailing list of the Libabigail project <libabigail.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/libabigail>,
 <mailto:libabigail-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/libabigail/>
List-Help: <mailto:libabigail-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/libabigail>,
 <mailto:libabigail-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Wed, 03 Feb 2021 13:14:16 -0000

https://sourceware.org/bugzilla/show_bug.cgi?id=3D27331

dodji at redhat dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

--- Comment #1 from dodji at redhat dot com ---
The problem here seems to be that the leaf mode is not showing the equivale=
nt
of what the default mode is showing.

And the default mode is showing changes to the offset of the S::var data
member.

So I believe that the bug here is that the leaf reporting mode is not showi=
ng
changes the offset of a data member, in this particular case.

This particular issue should now be fixed by commit
https://sourceware.org/git/?p=3Dlibabigail.git;a=3Dcommit;h=3D013a19c5fe300=
265f3fadc27963f84bde2c3b6ef
in the mainline branch.

However, it appears that libabigail doesn't represent the size of bitfields=
.=20
It thus doesn't detect the size of those bitfields, per say.  It will only
indirectly detect changes to those size when they affect other properties of
the type, like the offset of subsequent data members or the size of the
enclosing type.

In the grand scheme of things, it would be cool to detect bitfield changes =
even
if they don't affect subsequent data member offsets or the size of the
enclosing type.  To that effect, the enhancement request #27334 has been fi=
led.

Thanks for taking the time to report this issue!

--=20
You are receiving this mail because:
You are on the CC list for the bug.=