public inbox for libabigail@sourceware.org
 help / color / mirror / Atom feed
From: "gprocida+abigail at google dot com" <sourceware-bugzilla@sourceware.org>
To: libabigail@sourceware.org
Subject: [Bug default/27552] New: libandroid.so missing symbol type information
Date: Tue, 09 Mar 2021 16:20:17 +0000	[thread overview]
Message-ID: <bug-27552-9487@http.sourceware.org/bugzilla/> (raw)

https://sourceware.org/bugzilla/show_bug.cgi?id=27552

            Bug ID: 27552
           Summary: libandroid.so missing symbol type information
           Product: libabigail
           Version: unspecified
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: default
          Assignee: dodji at redhat dot com
          Reporter: gprocida+abigail at google dot com
                CC: libabigail at sourceware dot org
  Target Milestone: ---

The libandroid.so library is now part of the libabigail test suite, as is an
ABI extracted from this.

I noticed that the names used of the ELF symbols and the names of declared
variables and functions, as found in the ABI, are disjoint.

I verified that:
1. if a symbol is added or removed, this is reported
2. if any type information changes, this is not reported

An examination of libandroid.so with nm -o and dwarfdump confirms that symbol
names are properly present in the DWARF.

For example, from the dwarfdump:

< 1><0x00024873>    DW_TAG_subprogram
                      DW_AT_low_pc                0x0000ce62
                      DW_AT_high_pc               <offset-from-lowpc>38
                      DW_AT_frame_base            len 0x0001: 0x5d: 
                          DW_OP_reg13
                      DW_AT_GNU_all_call_sites    yes(1)
                      DW_AT_name                  AAssetDir_close
                      DW_AT_decl_file             0x00000034
frameworks/base/native/android/asset_manager.cpp
                      DW_AT_decl_line             0x0000008c
                      DW_AT_external              yes(1)
< 2><0x00024885>      DW_TAG_formal_parameter
                        DW_AT_location              0x00001332
      .debug_loc      offset  : 0x00001332
      <loclist at offset 0x00001332 with 4 entries follows>
   [ 0]<base address       0x0000ce62>
   [ 1]<low,hi addrs       0x0000ce62 , 0x0000ce68>
                            DW_OP_reg0
   [ 2]<low,hi addrs       0x0000ce68 , 0x0000ce82>
                            DW_OP_reg4
   [ 3]<low,hi addrs       0x0000ce86 , 0x0000ce88>
                            DW_OP_reg0
                        DW_AT_name                  assetDir
                        DW_AT_decl_file             0x00000034
frameworks/base/native/android/asset_manager.cpp
                        DW_AT_decl_line             0x0000008c
                        DW_AT_type                  <0x00024e40>
< 2><0x00024894>      DW_TAG_inlined_subroutine
...


If I discover anything further, I'll follow up here.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

             reply	other threads:[~2021-03-09 16:20 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-09 16:20 gprocida+abigail at google dot com [this message]
2021-03-09 20:21 ` [Bug default/27552] " gprocida+abigail at google dot com
2021-03-09 21:49 ` mark at klomp dot org
2021-03-09 22:29 ` [Bug default/27552] libabigail needs to interpret ARM32 symbol addresses specially gprocida+abigail at google dot com
2021-03-22 17:42 ` dodji at redhat dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-27552-9487@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=libabigail@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).