From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sourceware-bugzilla@sourceware.org>
Received: by sourceware.org (Postfix, from userid 48)
 id 2FC063858C27; Mon, 15 Mar 2021 13:17:35 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2FC063858C27
From: "gprocida+abigail at google dot com" <sourceware-bugzilla@sourceware.org>
To: libabigail@sourceware.org
Subject: [Bug default/27569] abidiff misses a function parameter addition
Date: Mon, 15 Mar 2021 13:17:35 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: libabigail
X-Bugzilla-Component: default
X-Bugzilla-Version: unspecified
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: gprocida+abigail at google dot com
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: dodji at redhat dot com
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-27569-9487-fpIaHzzATa@http.sourceware.org/bugzilla/>
In-Reply-To: <bug-27569-9487@http.sourceware.org/bugzilla/>
References: <bug-27569-9487@http.sourceware.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: libabigail@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Mailing list of the Libabigail project <libabigail.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/libabigail>,
 <mailto:libabigail-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/libabigail/>
List-Help: <mailto:libabigail-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/libabigail>,
 <mailto:libabigail-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Mon, 15 Mar 2021 13:17:35 -0000

https://sourceware.org/bugzilla/show_bug.cgi?id=3D27569

--- Comment #1 from Giuliano Procida <gprocida+abigail at google dot com> -=
--
I've done a little more investigation.

HARMLESS_UNION_CHANGE_CATEGORY|FN_RETURN_TYPE_CV_CHANGE_CATEGORY are indeed
inherited/propagated categories.

The function decl diff has is_filtered_out returning false before categories
are propagated to returning true afterwards.

So I think the problem is that NO_CHANGE_CATEGORY is the incorrect local
category to start off with.

I also think the only reason problems have not been noticed before is that
is_filtered_out contains the suspicious-looking:

  if (category =3D=3D NO_CHANGE_CATEGORY)
    return false;

This catches the common case of no special categories being propagated to a
node containing a real diff. If it's removed, abidiff stops finding a lot of
diffs.

--=20
You are receiving this mail because:
You are on the CC list for the bug.=