public inbox for libabigail@sourceware.org
 help / color / mirror / Atom feed
From: "marcandre.lureau at gmail dot com" <sourceware-bugzilla@sourceware.org>
To: libabigail@sourceware.org
Subject: [Bug default/27715] Fails to detect GObjectClass ABI changes
Date: Mon, 12 Apr 2021 19:01:26 +0000	[thread overview]
Message-ID: <bug-27715-9487-bwCHRRRt48@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-27715-9487@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=27715

--- Comment #8 from Marc-André Lureau <marcandre.lureau at gmail dot com> ---
(In reply to Matthias Maennich from comment #7)
> Thanks for that.
> 
> I can see that:
>  - _GTypeModuleClass increases in size from old->new in DWARF
>  - old and new have debug information sufficient for ABI analysis
>  - _GTypeModuleClass is not attached directly or indirectly as a type to any
> ELF symbol
> 
> Can you please tell me which symbol you would expect to become incompatible
> based on a change to this class? How does it relate to any of the exported
> symbols?

FooClass/vtable (and other object-oriented structures) are often passed around
as void * (or parent types) on the public functions etc. However, the
implementation then cast the void/parent pointer to some concrete type, and
expect the structure to keep the same layout.

So any change in those OO structures is an ABI break, it would be nice to catch
them.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

  parent reply	other threads:[~2021-04-12 19:01 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-09 17:05 [Bug default/27715] New: " marcandre.lureau at gmail dot com
2021-04-09 17:54 ` [Bug default/27715] " maennich at android dot com
2021-04-12  8:21 ` marcandre.lureau at gmail dot com
2021-04-12  9:49 ` maennich at android dot com
2021-04-12 13:54 ` marcandre.lureau at gmail dot com
2021-04-12 13:55 ` marcandre.lureau at gmail dot com
2021-04-12 13:55 ` marcandre.lureau at gmail dot com
2021-04-12 14:05 ` maennich at android dot com
2021-04-12 19:01 ` marcandre.lureau at gmail dot com [this message]
2021-04-14 10:53 ` maennich at android dot com
2021-04-20 11:55 ` marcandre.lureau at gmail dot com
2021-04-29 15:13 ` marcandre.lureau at gmail dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-27715-9487-bwCHRRRt48@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=libabigail@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).