From: "gprocida+abigail at google dot com" <sourceware-bugzilla@sourceware.org>
To: libabigail@sourceware.org
Subject: [Bug default/27769] New: XML reader shares a corpus object between corpora
Date: Fri, 23 Apr 2021 07:52:46 +0000 [thread overview]
Message-ID: <bug-27769-9487@http.sourceware.org/bugzilla/> (raw)
https://sourceware.org/bugzilla/show_bug.cgi?id=27769
Bug ID: 27769
Summary: XML reader shares a corpus object between corpora
Product: libabigail
Version: unspecified
Status: UNCONFIRMED
Severity: normal
Priority: P2
Component: default
Assignee: dodji at redhat dot com
Reporter: gprocida+abigail at google dot com
CC: libabigail at sourceware dot org
Target Milestone: ---
Created attachment 13396
--> https://sourceware.org/bugzilla/attachment.cgi?id=13396&action=edit
fresh corpus object patch
Commit ebaf3305bc5adc5eb45cca2dbb9b7d94b99b6800 added a more detailed error
message around an assertion about architecture consistency.
I revisited the trigger for this today as I've been testing using whole
histories of XML versions, including a few ABIs which contained stray objects
from a different architecture. Note that the corpora in the XML were
consistently of one architecture each (as abi-instr has no architecture
attribute).
I also separately noticed yesterday that parts of the ABI get dropped if the
same abi-instr path is used in multiple corpora.
Both the assertion failure and the path collision issue go away if the XML
reader allocates a fresh corpus object for each corpus element. I have a
trivial patch to do this (and the test suite passes). However, I haven't yet
looked into whether there was an underlying reason for re-using the corpus
object.
I've attached the patch here for completeness.
--
You are receiving this mail because:
You are on the CC list for the bug.
next reply other threads:[~2021-04-23 7:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-23 7:52 gprocida+abigail at google dot com [this message]
2021-04-23 15:31 ` [Bug default/27769] " gprocida+abigail at google dot com
2021-04-27 11:32 ` gprocida+abigail at google dot com
2021-08-23 8:59 ` gprocida at google dot com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-27769-9487@http.sourceware.org/bugzilla/ \
--to=sourceware-bugzilla@sourceware.org \
--cc=libabigail@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).