public inbox for libabigail@sourceware.org
 help / color / mirror / Atom feed
From: "gprocida at google dot com" <sourceware-bugzilla@sourceware.org>
To: libabigail@sourceware.org
Subject: [Bug default/27985] New: abidiff: bad array types in report
Date: Wed, 16 Jun 2021 11:04:23 +0000	[thread overview]
Message-ID: <bug-27985-9487@http.sourceware.org/bugzilla/> (raw)

https://sourceware.org/bugzilla/show_bug.cgi?id=27985

            Bug ID: 27985
           Summary: abidiff: bad array types in report
           Product: libabigail
           Version: unspecified
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: default
          Assignee: dodji at redhat dot com
          Reporter: gprocida at google dot com
                CC: libabigail at sourceware dot org
  Target Milestone: ---

Created attachment 13496
  --> https://sourceware.org/bugzilla/attachment.cgi?id=13496&action=edit
two XML files to compare

This is a regression which I've bisected to the recent commit
9681ab04d20f8dacdb14404f6234f63a62e61dd2 "Fix recursive array type definition".

The attached XML files were generated straightforwardly with abidw. The source
files look like the following.

--- indirect_c.0.c   2020-07-31 13:35:19.000000000 +0100
+++ indirect_c.1.c   2020-07-31 13:35:19.000000000 +0100
@@ -1,9 +1,9 @@
 struct leaf {
-  int numbers[2];
+  int numbers[3];
 };

 struct node {
   struct leaf* ptr;
 };

 void foo(struct node *n) { (void) n; }

The resulting abidiff output contains:

                type of 'int numbers[2]' changed:
                  type name changed from 'void[2]' to 'void[3]'
                  array type size changed from 64 to 96
                  array type subrange 1 changed length from 2 to 3

instead of

                type of 'int numbers[2]' changed:
                  type name changed from 'int[2]' to 'int[3]'
                  array type size changed from 64 to 96
                  array type subrange 1 changed length from 2 to 3

-- 
You are receiving this mail because:
You are on the CC list for the bug.

             reply	other threads:[~2021-06-16 11:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-16 11:04 gprocida at google dot com [this message]
2021-08-13  7:01 ` [Bug default/27985] " gprocida at google dot com
2021-09-02 16:30 ` dodji at redhat dot com
2021-09-03  9:14 ` dodji at redhat dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-27985-9487@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=libabigail@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).