public inbox for libabigail@sourceware.org
 help / color / mirror / Atom feed
From: "gprocida at google dot com" <sourceware-bugzilla@sourceware.org>
To: libabigail@sourceware.org
Subject: [Bug default/27995] abidiff performance regression
Date: Thu, 01 Jul 2021 16:13:19 +0000	[thread overview]
Message-ID: <bug-27995-9487-PGgVn27wiC@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-27995-9487@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=27995

--- Comment #3 from gprocida at google dot com ---
This does indeed fix the issue.

It may also speed up other cases where abidiff takes quite a while. Checking...

A kernel ABI XML diff I'm using for performance measurement at origin/PR27995:

real    1m25.813s
user    1m25.361s
sys     0m0.452s

And at current origin/master:

real    2m47.301s
user    2m46.856s
sys     0m0.442s

This is a real improvement!

I even diff'd the diffs and the new one looks better. There was an odd line,
mentioning indirect sub-type changes but not followed by any diff text, in the
old one.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

  parent reply	other threads:[~2021-07-01 16:13 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-18 13:08 [Bug default/27995] New: " gprocida at google dot com
2021-06-18 15:30 ` [Bug default/27995] " gprocida at google dot com
2021-06-21  8:53 ` dodji at redhat dot com
2021-07-01 14:21 ` dodji at redhat dot com
2021-07-01 16:13 ` gprocida at google dot com [this message]
2021-08-13  7:05 ` gprocida at google dot com
2022-01-21 12:25 ` gprocida at google dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-27995-9487-PGgVn27wiC@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=libabigail@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).