public inbox for libabigail@sourceware.org
 help / color / mirror / Atom feed
From: "gprocida at google dot com" <sourceware-bugzilla@sourceware.org>
To: libabigail@sourceware.org
Subject: [Bug default/28013] New: abidiff assertion failure
Date: Fri, 25 Jun 2021 23:20:50 +0000	[thread overview]
Message-ID: <bug-28013-9487@http.sourceware.org/bugzilla/> (raw)

https://sourceware.org/bugzilla/show_bug.cgi?id=28013

            Bug ID: 28013
           Summary: abidiff assertion failure
           Product: libabigail
           Version: unspecified
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: default
          Assignee: dodji at redhat dot com
          Reporter: gprocida at google dot com
                CC: libabigail at sourceware dot org
  Target Milestone: ---

This small case triggers an assertion failure. If assertions are disabled the
output looks sane.

abidiff: ../../src/abg-ir.cc:24767: size_t
abigail::ir::hash_as_canonical_type_or_constant(const abigail::ir::type_base*):
Assertion `__abg_cond__' failed.
Aborted

==> fn_variadic_c.0.abi <==
<abi-corpus version='2.0' path='fn_variadic_c.0.o'
architecture='elf-amd-x86_64'>
  <elf-function-symbols>
    <elf-symbol name='foo1' type='func-type' binding='global-binding'
visibility='default-visibility' is-defined='yes'/>
    <elf-symbol name='foo2' type='func-type' binding='global-binding'
visibility='default-visibility' is-defined='yes'/>
    <elf-symbol name='foo3' type='func-type' binding='global-binding'
visibility='default-visibility' is-defined='yes'/>
  </elf-function-symbols>
  <abi-instr address-size='64' path='fn_variadic_c.0.c' language='LANG_C99'>
    <type-decl name='int' size-in-bits='32' id='95e97e5e'/>
    <type-decl name='variadic parameter type' id='2c1145c5'/>
    <function-decl name='foo3' mangled-name='foo3' visibility='default'
binding='global' size-in-bits='64' elf-symbol-id='foo3'>
      <parameter type-id='95e97e5e' name='x'/>
      <parameter type-id='95e97e5e' name='y'/>
      <parameter is-variadic='yes'/>
      <return type-id='95e97e5e'/>
    </function-decl>
    <function-decl name='foo2' mangled-name='foo2' visibility='default'
binding='global' size-in-bits='64' elf-symbol-id='foo2'>
      <parameter type-id='95e97e5e' name='x'/>
      <parameter type-id='95e97e5e' name='y'/>
      <return type-id='95e97e5e'/>
    </function-decl>
    <function-decl name='foo1' mangled-name='foo1' visibility='default'
binding='global' size-in-bits='64' elf-symbol-id='foo1'>
      <parameter type-id='95e97e5e' name='x'/>
      <parameter type-id='95e97e5e' name='y'/>
      <return type-id='95e97e5e'/>
    </function-decl>
  </abi-instr>
</abi-corpus>

==> fn_variadic_c.1.abi <==
<abi-corpus version='2.0' path='fn_variadic_c.1.o'
architecture='elf-amd-x86_64'>
  <elf-function-symbols>
    <elf-symbol name='foo1' type='func-type' binding='global-binding'
visibility='default-visibility' is-defined='yes'/>
    <elf-symbol name='foo2' type='func-type' binding='global-binding'
visibility='default-visibility' is-defined='yes'/>
    <elf-symbol name='foo3' type='func-type' binding='global-binding'
visibility='default-visibility' is-defined='yes'/>
  </elf-function-symbols>
  <abi-instr address-size='64' path='fn_variadic_c.1.c' language='LANG_C99'>
    <type-decl name='int' size-in-bits='32' id='95e97e5e'/>
    <type-decl name='variadic parameter type' id='2c1145c5'/>
    <function-decl name='foo3' mangled-name='foo3' visibility='default'
binding='global' size-in-bits='64' elf-symbol-id='foo3'>
      <parameter type-id='95e97e5e' name='x'/>
      <parameter type-id='95e97e5e' name='y'/>
      <return type-id='95e97e5e'/>
    </function-decl>
    <function-decl name='foo2' mangled-name='foo2' visibility='default'
binding='global' size-in-bits='64' elf-symbol-id='foo2'>
      <parameter type-id='95e97e5e' name='x'/>
      <parameter is-variadic='yes'/>
      <return type-id='95e97e5e'/>
    </function-decl>
    <function-decl name='foo1' mangled-name='foo1' visibility='default'
binding='global' size-in-bits='64' elf-symbol-id='foo1'>
      <parameter type-id='95e97e5e' name='x'/>
      <parameter type-id='95e97e5e' name='y'/>
      <parameter is-variadic='yes'/>
      <return type-id='95e97e5e'/>
    </function-decl>
  </abi-instr>
</abi-corpus>

It's also interesting that the XML contains a variadic parameter type but this
isn't used in the parameter lists.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

             reply	other threads:[~2021-06-25 23:20 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-25 23:20 gprocida at google dot com [this message]
2021-06-26  5:46 ` [Bug default/28013] " gprocida at google dot com
2021-07-14  8:52 ` gprocida at google dot com
2021-08-12 22:14 ` gprocida at google dot com
2022-01-14 16:10 ` gprocida at google dot com
2022-03-07  9:42 ` dodji at redhat dot com
2022-03-07 11:07 ` dodji at redhat dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-28013-9487@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=libabigail@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).