From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sourceware-bugzilla@sourceware.org>
Received: by sourceware.org (Postfix, from userid 48)
 id 070CF3850438; Wed,  4 Aug 2021 16:41:48 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 070CF3850438
From: "gprocida at google dot com" <sourceware-bugzilla@sourceware.org>
To: libabigail@sourceware.org
Subject: [Bug default/28191] New: DWARF5 .debug_addr support
Date: Wed, 04 Aug 2021 16:41:47 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: libabigail
X-Bugzilla-Component: default
X-Bugzilla-Version: unspecified
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: gprocida at google dot com
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: dodji at redhat dot com
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: bug_id short_desc product version bug_status
 bug_severity priority component assigned_to reporter cc target_milestone
Message-ID: <bug-28191-9487@http.sourceware.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: libabigail@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Mailing list of the Libabigail project <libabigail.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/libabigail>,
 <mailto:libabigail-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/libabigail/>
List-Help: <mailto:libabigail-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/libabigail>,
 <mailto:libabigail-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Wed, 04 Aug 2021 16:41:48 -0000

https://sourceware.org/bugzilla/show_bug.cgi?id=3D28191

            Bug ID: 28191
           Summary: DWARF5 .debug_addr support
           Product: libabigail
           Version: unspecified
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: default
          Assignee: dodji at redhat dot com
          Reporter: gprocida at google dot com
                CC: libabigail at sourceware dot org
  Target Milestone: ---

libabigail doesn't know about .debug_addr and DW_OP_addrx.

The result is that symbols (silently) end up with no type information.

This is a blocker for migrating the Android kernel to DWARF 5 and is already
affecting ABI monitoring of Android userspace libraries.

Test case:

$ cat foo.c
int x =3D 1;
$ clang-11 -gdwarf-4 -c foo.c=20
$ abidw foo.o
<abi-corpus version=3D'2.0' path=3D'foo.o' architecture=3D'elf-amd-x86_64'>
  <elf-variable-symbols>
    <elf-symbol name=3D'x' size=3D'4' type=3D'object-type' binding=3D'globa=
l-binding'
visibility=3D'default-visibility' is-defined=3D'yes'/>
  </elf-variable-symbols>
  <abi-instr address-size=3D'64' path=3D'foo.c'
comp-dir-path=3D'/usr/local/google/home/gprocida/dev/libabigail/b195152239'
language=3D'LANG_C99'>
    <type-decl name=3D'int' size-in-bits=3D'32' id=3D'type-id-1'/>
    <var-decl name=3D'x' type-id=3D'type-id-1' mangled-name=3D'x'
visibility=3D'default'
filepath=3D'/usr/local/google/home/gprocida/dev/libabigail/b1
95152239/foo.c' line=3D'1' column=3D'1' elf-symbol-id=3D'x'/>
  </abi-instr>
</abi-corpus>
$ clang-11 -gdwarf-5 -c foo.c=20
$ abidw foo.o
<abi-corpus version=3D'2.0' path=3D'foo.o' architecture=3D'elf-amd-x86_64'>
  <elf-variable-symbols>
    <elf-symbol name=3D'x' size=3D'4' type=3D'object-type' binding=3D'globa=
l-binding'
visibility=3D'default-visibility' is-defined=3D'yes'/>
  </elf-variable-symbols>
</abi-corpus>

dwarfdump snippets:

< 1><0x0000001e>    DW_TAG_variable
                      DW_AT_name                  x
                      DW_AT_type                  <0x00000033>
                      DW_AT_external              yes(1)
                      DW_AT_decl_file             0x00000001
/usr/local/google/home/gprocida/dev/libabigail/b195152239/foo.c
                      DW_AT_decl_line             0x00000001
                      DW_AT_location              len 0x0009:
0x030000000000000000:=20
                          DW_OP_addr 0x00000000

< 1><0x0000001e>    DW_TAG_variable
                      DW_AT_name                  (indexed string: 0x000000=
03)x
                      DW_AT_type                  <0x00000029>
                      DW_AT_external              yes(1)
                      DW_AT_decl_file             0x00000000
/usr/local/google/home/gprocida/dev/libabigail/b195152239/foo.c
                      DW_AT_decl_line             0x00000001
                      DW_AT_location              len 0x0002: 0xa100:=20
                          DW_OP_addrx 0

--=20
You are receiving this mail because:
You are on the CC list for the bug.=