public inbox for libabigail@sourceware.org
 help / color / mirror / Atom feed
From: "lukas at wunner dot de" <sourceware-bugzilla@sourceware.org>
To: libabigail@sourceware.org
Subject: [Bug default/28289] [1.7 -> 1.8 regression] false positives involving enum synthetic type names
Date: Sun, 05 Sep 2021 13:48:01 +0000	[thread overview]
Message-ID: <bug-28289-9487-otxnhd74zN@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-28289-9487@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=28289

lukas at wunner dot de changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |WONTFIX
             Status|UNCONFIRMED                 |RESOLVED

--- Comment #5 from lukas at wunner dot de ---
In reply to gprocida from comment #4)
> The commit, like other changes over the last year, resulted in changes to
> the ABI representation for the same input. As you point out, the name change
> triggers abidiff. In post-1.8 development the (first, partial) bitfield
> offset fix warranted an XML version bump, making abidiff refuse to compare
> mismatched XML files, but no such thing was done for the 1.7->1.8 changes.

Thanks for the explanation Giuliano.

The OpenZFS project now works around the issue by forcing version 1.8 or newer:
https://github.com/openzfs/zfs/commit/a9655fc2bd1f

And the project's *.abi files have been regenerated with v1.8:
https://github.com/openzfs/zfs/commit/6ea058da16cc

Hopefully in the future there won't be any silent changes in the XML file
format which trigger abidiff.

Closing this. Thanks again.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

      parent reply	other threads:[~2021-09-05 13:48 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-30  7:20 [Bug default/28289] New: " lukas at wunner dot de
2021-08-30  7:24 ` [Bug default/28289] " lukas at wunner dot de
2021-08-30  7:28 ` lukas at wunner dot de
2021-08-30  7:28 ` lukas at wunner dot de
2021-08-30  7:29 ` lukas at wunner dot de
2021-08-30  7:43 ` gprocida at google dot com
2021-09-05 13:48 ` lukas at wunner dot de [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-28289-9487-otxnhd74zN@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=libabigail@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).