public inbox for libabigail@sourceware.org
 help / color / mirror / Atom feed
From: "lukas at wunner dot de" <sourceware-bugzilla@sourceware.org>
To: libabigail@sourceware.org
Subject: [Bug default/28289] New: [1.7 -> 1.8 regression] false positives involving enum synthetic type names
Date: Mon, 30 Aug 2021 07:20:57 +0000	[thread overview]
Message-ID: <bug-28289-9487@http.sourceware.org/bugzilla/> (raw)

https://sourceware.org/bugzilla/show_bug.cgi?id=28289

            Bug ID: 28289
           Summary: [1.7 -> 1.8 regression] false positives involving enum
                    synthetic type names
           Product: libabigail
           Version: unspecified
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: default
          Assignee: dodji at redhat dot com
          Reporter: lukas at wunner dot de
                CC: gprocida at google dot com, libabigail at sourceware dot org
  Target Milestone: ---

Created attachment 13633
  --> https://sourceware.org/bugzilla/attachment.cgi?id=13633&action=edit
full abidiff output

Invoking abidiff v1.8 (or newer) on libzfs results in 74 reported changes if
the .abi file was generated with an abidiff version < 1.8.

The changes are not reported if abidiff v1.7 or an older version is used.

git bisect identified this as the first bad commit:

    commit 8a0825e319c3c3430706ca4f7f330259dfc85563
    Author: Giuliano Procida <gprocida@google.com>
    Date:   Thu Oct 29 12:20:59 2020 +0000

    Improve enum synthetic type names

The reported changes seem nonsensical as there are "no data member changes":

  [C] 'function prop_changelist_t* changelist_gather(zfs_handle_t*, zfs_prop_t,
int, int)' at libzfs_changelist.c:624:1 has some indirect sub-type changes:
    parameter 1 of type 'zfs_handle_t*' has sub-type changes:
      in pointed to type 'typedef zfs_handle_t' at libzfs.h:195:1:
        underlying type 'struct zfs_handle' at libzfs_impl.h:77:1 changed:
          type size hasn't changed
          1 data member changes (5 filtered):
            type of 'libzfs_handle_t* zfs_handle::zfs_hdl' changed:
              in pointed to type 'typedef libzfs_handle_t' at libzfs.h:197:1:
                underlying type 'struct libzfs_handle' at libzfs_impl.h:48:1
changed:
                  type size hasn't changed
                  no data member changes (4 filtered);

The issue is tracked here:
https://github.com/openzfs/zfs/issues/12360

-- 
You are receiving this mail because:
You are on the CC list for the bug.

             reply	other threads:[~2021-08-30  7:20 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-30  7:20 lukas at wunner dot de [this message]
2021-08-30  7:24 ` [Bug default/28289] " lukas at wunner dot de
2021-08-30  7:28 ` lukas at wunner dot de
2021-08-30  7:28 ` lukas at wunner dot de
2021-08-30  7:29 ` lukas at wunner dot de
2021-08-30  7:43 ` gprocida at google dot com
2021-09-05 13:48 ` lukas at wunner dot de

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-28289-9487@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=libabigail@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).