From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sourceware-bugzilla@sourceware.org>
Received: by sourceware.org (Postfix, from userid 48)
 id 330D2393A42B; Wed, 12 Jan 2022 11:25:16 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 330D2393A42B
From: "gprocida at google dot com" <sourceware-bugzilla@sourceware.org>
To: libabigail@sourceware.org
Subject: [Bug default/28319] abidw - regression in treatment of anonymous
 enums in structs
Date: Wed, 12 Jan 2022 11:25:16 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: libabigail
X-Bugzilla-Component: default
X-Bugzilla-Version: unspecified
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: gprocida at google dot com
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: dodji at redhat dot com
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-28319-9487-G4HSTjMiF4@http.sourceware.org/bugzilla/>
In-Reply-To: <bug-28319-9487@http.sourceware.org/bugzilla/>
References: <bug-28319-9487@http.sourceware.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: libabigail@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Mailing list of the Libabigail project <libabigail.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/libabigail>,
 <mailto:libabigail-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/libabigail/>
List-Help: <mailto:libabigail-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/libabigail>,
 <mailto:libabigail-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Wed, 12 Jan 2022 11:25:16 -0000

https://sourceware.org/bugzilla/show_bug.cgi?id=3D28319

--- Comment #8 from gprocida at google dot com ---
I tried another version which left the default at the environment level int=
act.

https://sourceware.org/pipermail/libabigail/2022q1/004071.html

However, type comparisons performed *outside* compare_before_canonicalisati=
on
were still being done ignoring enumerator names and this is what seems to
matter (at least for the vmlinux test case here).

As things stand, the use_enum_binary_only_equality code in
compare_before_canonicalisation does nothing as the values before/after are=
 all
true.

Fixing the default in environment fixes this bug.

I'll post a new commit.

--=20
You are receiving this mail because:
You are on the CC list for the bug.=