public inbox for libabigail@sourceware.org
 help / color / mirror / Atom feed
From: "dodji at seketeli dot org" <sourceware-bugzilla@sourceware.org>
To: libabigail@sourceware.org
Subject: [Bug default/28584] Clang doesn't emit DW_AT_external for some global variables so they are dropped by libabigail
Date: Tue, 16 Nov 2021 14:08:47 +0000	[thread overview]
Message-ID: <bug-28584-9487-MCwwWubyBr@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-28584-9487@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=28584

--- Comment #7 from dodji at seketeli dot org ---
gprocida at google dot com via Libabigail <libabigail@sourceware.org> a
écrit:

> https://sourceware.org/bugzilla/show_bug.cgi?id=28584
>
> --- Comment #6 from gprocida at google dot com ---
> FTR, I was using Debian's dwarfdump from dwarfutils.
>
> Architecture: amd64
> Source: dwarfutils
> Version: 20210528-1
> Depends: libc6 (>= 2.14), libdwarf1 (>= 20210528), libelf1 (>= 0.131)
> Description: utility to dump DWARF debug information from ELF objects
>  Dwarfdump is an application that can print the DWARF debugging
>  information of an ELF object file in a human-readable form. It can
>  also be used to check and validate manipulated DWARF sections.
>  .
>  This utility is part of dwarfutils.
> Homepage: https://www.prevanders.net/dwarf.html

Thanks.

> I not that familiar with DWARF, but I was reading both the GCC and Clang DWARF
> as having two linked DIEs, one of which referred (via specification) to the
> other (containing external).
>
> The real difference is just the scope at which the one DIE appeared.

Even when you look at the behavious of the DWARF reader in the debugger,
that difference of scope of the concrete-instance DIE doesn't matter.
To determine the real scope of the variable represented by the DIE, what
matters is the scope of the specification DIE of that concrete
instance.  And that is what libabigail takes into account.

> As regards whether the change improves the library ABIs:
>
> 1594 extra symbols are now typed (yay!)

That's progress, I guess.

> 27124 symbols remain untyped, 21144 of which don't appear in the DWARF (as a
> linkname) at all - Clang or some other build issue
>
> This leaves 5980 where they are there in the debug info (as a linkname) but not
> appearing in the ABI. Could be a Clang bug or Clang/libabigail
> disagreement.

> I'll continue to look into these 5980 and see if I can come up with small test
> cases to report.

OK.  So maybe we can close this bug then and open a new meta one with
some broader ?

Thanks!

-- 
You are receiving this mail because:
You are on the CC list for the bug.

  parent reply	other threads:[~2021-11-16 14:08 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-11 12:15 [Bug default/28584] New: abidw doesn't get Clang DWARF type information for certain symbols gprocida at google dot com
2021-11-12 13:09 ` [Bug default/28584] " gprocida at google dot com
2021-11-12 14:05 ` gprocida at google dot com
2021-11-15 15:25 ` dodji at redhat dot com
2021-11-15 16:10 ` [Bug default/28584] Clang doesn't emit DW_AT_external for some global variables so they are dropped by libabigail dodji at redhat dot com
2021-11-15 16:42 ` dodji at redhat dot com
2021-11-15 21:05 ` gprocida at google dot com
2021-11-16  7:34 ` dodji at redhat dot com
2021-11-16 10:57 ` gprocida at google dot com
2021-11-16 14:08   ` Dodji Seketeli
2021-11-16 14:08 ` dodji at seketeli dot org [this message]
2021-11-16 15:30 ` gprocida at google dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-28584-9487-MCwwWubyBr@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=libabigail@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).