From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id 632303858426; Wed, 8 Dec 2021 18:54:32 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 632303858426 From: "woodard at redhat dot com" To: libabigail@sourceware.org Subject: [Bug default/28641] unspecified indirect subtype changes. Date: Wed, 08 Dec 2021 18:54:32 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: libabigail X-Bugzilla-Component: default X-Bugzilla-Version: unspecified X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: woodard at redhat dot com X-Bugzilla-Status: NEW X-Bugzilla-Resolution: X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: dodji at redhat dot com X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Dec 2021 18:54:32 -0000 https://sourceware.org/bugzilla/show_bug.cgi?id=3D28641 --- Comment #6 from Ben Woodard --- The functions that I pointed out in the previous comment are all _ZNK functions. You can overload on the const'ness of a function and so it has t= o be encoded in the mangling of the linkage name. struct X { void foo(); void foo() const; }; We should try to get this fixed in clang so that it correctly encodes the const'ness of the function in the DWARF. However, we are going to need to d= eal with all the versions of clang which don't get this right. So I propose a fixup: if the function has the K attribute in its name mangling even if the function's DWARF is not marked const then the function should be labeled as const. List of needed actions: 1) file a bug with clang 2) when the difference between two functions is const'ness print that out d= on't just leave people with "...has some indirect sub-type changes:" then print nothing. 3) if the function mangle name has the K in it, then mark it const in the I= R. --=20 You are receiving this mail because: You are on the CC list for the bug.=