public inbox for libabigail@sourceware.org
 help / color / mirror / Atom feed
From: "woodard at redhat dot com" <sourceware-bugzilla@sourceware.org>
To: libabigail@sourceware.org
Subject: [Bug default/28976] Optionally ignore SONAME when comparing libraries
Date: Tue, 28 Jun 2022 22:28:07 +0000	[thread overview]
Message-ID: <bug-28976-9487-bM1jhoDJH1@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-28976-9487@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=28976

Ben Woodard <woodard at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #4 from Ben Woodard <woodard at redhat dot com> ---
This patch has been merged. 

commit c7a71ba2d146d4253d96d27150a741bc3290d275
Author: Ben Woodard <woodard@redhat.com>
Date:   Wed May 4 10:42:29 2022 -0700

    Add an option ignore SONAME differences in libraries

    There are rare use cases where we do not want to compare the SONAME when
    testing libraries for compatiblity or diffing libraries. This adds an
    option to ignore the SONAME when doing the comparison. In these cases,
    we will edit the application's DT_NEEDED to point to the other library.

    This reuses the show_soname_change() function and slightly changes its
    meaning to not only control if the sonames are printed but also if
    they are compared. There didn't seem to be any other users of this
    function and slight semantic change seemed harmless.

            * doc/manuals/abicompat.rst - added new option
            * doc/manuals/abidiff.rst - added new option to manpage
            * src/abg-comparison.cc (compute_diff): don't bother comparing the
            sonames if you aren't going to print them.
            * tools/abicompat.cc (options::ignore_soname): Add new data
            member.
            (parse_command_line): Support the new --ignore-soname command line
            option.
            (display_usage): Add a description string for the new
            --ignore-soname command line option.
            (create_diff_context): Set the diff_context::show_soname_change
            from the new options::ignore_soname data member.
            * tools/abidiff.cc (options::ignore_soname): Add new data member.
            (display_usage): Add a description string for the new
            --ignore-soname command line option.
            (parse_command_line): Support the new --ignore-soname command line
            option.
            (set_diff_context_from_opts): Set the
            diff_context::show_soname_change from the new
            options::ignore_soname.

    Signed-off-by: Ben Woodard <woodard@redhat.com>
    Signed-off-by: Dodji Seketeli <dodji@redhat.com>

-- 
You are receiving this mail because:
You are on the CC list for the bug.

      parent reply	other threads:[~2022-06-28 22:28 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-17 22:01 [Bug default/28976] New: " woodard at redhat dot com
2022-03-17 22:02 ` [Bug default/28976] " woodard at redhat dot com
2022-03-21 14:59 ` woodard at redhat dot com
2022-03-21 15:04 ` maennich at android dot com
2022-03-21 19:21 ` woodard at redhat dot com
2022-03-31 21:33 ` woodard at redhat dot com
2022-06-28 22:28 ` woodard at redhat dot com [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-28976-9487-bM1jhoDJH1@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=libabigail@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).