From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id 3F1973839430; Thu, 31 Mar 2022 21:25:13 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3F1973839430 From: "woodard at redhat dot com" To: libabigail@sourceware.org Subject: [Bug default/29013] abicompat doesn't consider weak symbol replacement Date: Thu, 31 Mar 2022 21:25:13 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: libabigail X-Bugzilla-Component: default X-Bugzilla-Version: unspecified X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: woodard at redhat dot com X-Bugzilla-Status: NEW X-Bugzilla-Resolution: X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: dodji at redhat dot com X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 31 Mar 2022 21:25:13 -0000 https://sourceware.org/bugzilla/show_bug.cgi?id=3D29013 --- Comment #2 from Ben Woodard --- An example of where this could come up is when an application overrides a w= eak symbol like malloc(). Malloc is such a trivial example people are unlikely = to screw that up but the point remains the ABI of the overridden call must mat= ch the one who overrides. The additional logic to check weak symbols would be similar to the logic fo= und in tools/abicompat.cc around line 720 722 for (elf_symbols::const_iterator i =3D 723 app_corpus->get_sorted_undefined_fun_symbols().begin(); 724 i !=3D app_corpus->get_sorted_undefined_fun_symbols().en= d(); 725 ++i) There would need to be a similar iterator for weak symbols. --=20 You are receiving this mail because: You are on the CC list for the bug.=