From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sourceware-bugzilla@sourceware.org>
Received: by sourceware.org (Postfix, from userid 48)
 id 8CF3E385801E; Mon, 11 Apr 2022 10:08:52 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8CF3E385801E
From: "gprocida at google dot com" <sourceware-bugzilla@sourceware.org>
To: libabigail@sourceware.org
Subject: [Bug default/29044] New: abidiff reporter inconsistency
Date: Mon, 11 Apr 2022 10:08:52 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: libabigail
X-Bugzilla-Component: default
X-Bugzilla-Version: unspecified
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: gprocida at google dot com
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: dodji at redhat dot com
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: bug_id short_desc product version bug_status
 bug_severity priority component assigned_to reporter cc target_milestone
 attachments.created
Message-ID: <bug-29044-9487@http.sourceware.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: libabigail@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Mailing list of the Libabigail project <libabigail.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/libabigail>,
 <mailto:libabigail-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/libabigail/>
List-Help: <mailto:libabigail-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/libabigail>,
 <mailto:libabigail-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Mon, 11 Apr 2022 10:08:52 -0000

https://sourceware.org/bugzilla/show_bug.cgi?id=3D29044

            Bug ID: 29044
           Summary: abidiff reporter inconsistency
           Product: libabigail
           Version: unspecified
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: default
          Assignee: dodji at redhat dot com
          Reporter: gprocida at google dot com
                CC: libabigail at sourceware dot org
  Target Milestone: ---

Created attachment 14057
  --> https://sourceware.org/bugzilla/attachment.cgi?id=3D14057&action=3Ded=
it
XML inputs and abidiff outputs

Hi Dodji.

While digging into another issue, I noticed an inconsistency between whether
abidiff and abidiff --leaf-changes-only considers there to be a ABI break.

The attachment contains two Android kernel XML files. An independent check
shows that the only differences between them are whether certain types are =
only
declared or fully defined.

1. abidiff reports that ir_raw_handler_register's type has changed.

2. abidiff --leaf-changes-only does not.

3. abidiff --harmless results in reports of lots of cases where only-declar=
ed
vs fully-defined is considered to be a harmless change.

4. abidiff --leaf-changes-only --harmless results in a single report that
struct drm_crtc_helper_funcs has been changed, but the report doesn't reach=
 a
root cause.

In general, the inconsistency is a bit surprising, however, I think the best
places to look at in terms of bug hunting are 1 and 4 as, ignoring
only-declared vs fully-defined issues, nothing has changed between the two
ABIs.

Regards,
Giuliano.

--=20
You are receiving this mail because:
You are on the CC list for the bug.=