From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sourceware-bugzilla@sourceware.org>
Received: by sourceware.org (Postfix, from userid 48)
 id C263F385E440; Wed,  8 Jun 2022 15:39:07 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C263F385E440
From: "dodji at redhat dot com" <sourceware-bugzilla@sourceware.org>
To: libabigail@sourceware.org
Subject: [Bug default/29144] abidiff does not report base class reordering
Date: Wed, 08 Jun 2022 15:39:07 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: libabigail
X-Bugzilla-Component: default
X-Bugzilla-Version: unspecified
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: dodji at redhat dot com
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: dodji at redhat dot com
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-29144-9487-u9FdBErVOC@http.sourceware.org/bugzilla/>
In-Reply-To: <bug-29144-9487@http.sourceware.org/bugzilla/>
References: <bug-29144-9487@http.sourceware.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: libabigail@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Mailing list of the Libabigail project <libabigail.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/libabigail>,
 <mailto:libabigail-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/libabigail/>
List-Help: <mailto:libabigail-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/libabigail>,
 <mailto:libabigail-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Wed, 08 Jun 2022 15:39:07 -0000

https://sourceware.org/bugzilla/show_bug.cgi?id=3D29144

--- Comment #3 from dodji at redhat dot com ---
(In reply to gprocida from comment #2)
> Hi Dodji.
>=20
> I think this works, at least to some degree. However, we were wondering if
> it would make sense to mention *offsets* rather than just the *order* of
> base classes.
>=20
> There is also a second thing, one which I haven't had time to look into at
> all, beyond vaguely remembering the distinction and compiling some code.
> Something like the following. Or perhaps with s/class/struct/.
>=20
> class base { int x; };
> class a : base { int y;  };
> class b : base { int z; };
>=20
> class derived : a, b { };
>=20
> vs
>=20
> class derived : virtual a, virtual b { };
>=20
> I wonder if it's possible to get in a situation where layout changes are
> missed.

These are all valid points that I think we should revisit later when we are
more sure about what we want here.  For now, I have applied that patch to
master to at least detect something, rather than nothing.  I'll be glad to
explore this further when we are more sure about what we want.

I'll look at the later case you noted to see if we report anything at all.=
=20
Thanks!

--=20
You are receiving this mail because:
You are on the CC list for the bug.=