From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id C11DB382C156; Thu, 16 Jun 2022 16:28:56 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C11DB382C156 From: "gprocida at google dot com" To: libabigail@sourceware.org Subject: [Bug default/29175] handling of symbols outside the first corpus in a corpus group Date: Thu, 16 Jun 2022 16:28:56 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: libabigail X-Bugzilla-Component: default X-Bugzilla-Version: unspecified X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: gprocida at google dot com X-Bugzilla-Status: UNCONFIRMED X-Bugzilla-Resolution: X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: dodji at redhat dot com X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: short_desc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Jun 2022 16:28:56 -0000 https://sourceware.org/bugzilla/show_bug.cgi?id=3D29175 gprocida at google dot com changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|abidiff ignores symbols |handling of symbols outside |outside the first corpus of |the first corpus in a |a corpus group |corpus group --- Comment #1 from gprocida at google dot com --- There are a few things to consider in abidw and abidiff handling of corpus groups. Are symbols in later corpus groups picked up by abidiff? No (this is the original bug report). Can symbols be duplicated between different corpora? Yes. Someone is buildi= ng lots of modules in one tree (but devices only ship / use a subset of modules appropriate to the specific hardware). So only certain subsets of the corpo= ra are meaningful. Does abidw do the right thing in terms of scoping elf-symbol-id to within e= ach corpus rather than across the whole DWARF reader / corpus group? Possibly n= ot. What if symbol x is "int x" in one corpus but "int x(double)" in another? What will happen if parts of one type (say different member functions) are spread across multiple corpora? Please don't do this. I think it would be most useful if we could invent some test corpus groups, without actually building kernels and kernel modules. I'll talk to Matthias about this. It would then be much easier to test and validate abidw behaviour. --=20 You are receiving this mail because: You are on the CC list for the bug.=