From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id 9DAF13844003; Mon, 13 Jun 2022 09:29:40 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9DAF13844003 From: "dodji at seketeli dot org" To: libabigail@sourceware.org Subject: [Bug default/29239] abidiff - possibly unintentionally harmless diffs Date: Mon, 13 Jun 2022 09:29:40 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: libabigail X-Bugzilla-Component: default X-Bugzilla-Version: unspecified X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: dodji at seketeli dot org X-Bugzilla-Status: UNCONFIRMED X-Bugzilla-Resolution: X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: dodji at redhat dot com X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Jun 2022 09:29:40 -0000 https://sourceware.org/bugzilla/show_bug.cgi?id=3D29239 --- Comment #1 from dodji at seketeli dot org --- gprocida at google dot com via Libabigail a =C3=A9crit: Hello, > So struct foo has changed and the second half of struct boo has changed. > > abidiff treats 2 of the 6 changes as harmless. Is this intentional? The two changes that are flagged harmless are these: type of 'foo& lref1' changed: referenced type 'struct foo' changed, as reported earlier type of 'foo&& rref1' changed: referenced type 'struct foo' changed, as reported earlier They are actually "redundant" changes, meaning, the changes to struct foo have already been reported earlier. So these changes are just being left out of the report for "compactness", thus, hopefully, better legibility. So yes, that is intentional. Cheers, --=20 You are receiving this mail because: You are on the CC list for the bug.=