From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id D33BD3857B84; Thu, 14 Jul 2022 14:19:25 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D33BD3857B84 From: "dodji at redhat dot com" To: libabigail@sourceware.org Subject: [Bug default/29302] xeres-c doesn't self compare Date: Thu, 14 Jul 2022 14:19:25 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: libabigail X-Bugzilla-Component: default X-Bugzilla-Version: unspecified X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: dodji at redhat dot com X-Bugzilla-Status: RESOLVED X-Bugzilla-Resolution: FIXED X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: dodji at redhat dot com X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_status resolution Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Jul 2022 14:19:25 -0000 https://sourceware.org/bugzilla/show_bug.cgi?id=3D29302 dodji at redhat dot com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |FIXED --- Comment #5 from dodji at redhat dot com --- (In reply to dodji from comment #4) > (In reply to Ben Woodard from comment #3) > > The prototype patch seems to fix the problem with xerces-c, qt-virt-ma= nager > >=20 > > diff --git a/src/abg-dwarf-reader.cc b/src/abg-dwarf-reader.cc > > index 32a2cead..b71e94d7 100644 > > --- a/src/abg-dwarf-reader.cc > > +++ b/src/abg-dwarf-reader.cc > > @@ -14987,7 +14987,7 @@ build_function_decl(read_context& ctxt, > > result->set_symbol(fn_sym); > > string linkage_name =3D result->get_linkage_name(); > > if (linkage_name.empty() > > - || !fn_sym->get_alias_from_name(linkage_name)) > > + /*|| !fn_sym->get_alias_from_name(linkage_name)*/) > > result->set_linkage_name(fn_sym->get_name()); > > result->set_is_in_public_symbol_table(true); > > } >=20 > Cool!, thanks! >=20 > I have thus applied the patch at > https://sourceware.org/git/?p=3Dlibabigail.git;a=3Dcommit; > h=3De4c3d18aafbf94f48104f050cb1936a5e2ee5dcd. >=20=20 > > However it didn't seem to fix the problem with recoll which I would have > > classified in the same problem. I'm really not sure if that means that > > recoll has a different problem or if the solution is incomplete. >=20 > Hmmh, that issue (with the recoll package) seems to be different. Let me > look into it. >=20 > > Let me know if you want to close this one and have me file another one = or if > > you want to address both issues in this one bug report >=20 > I'll look into it. If it needs to be qualified differently, I'll do it, > thanks! OK, I have pushed a patch that should hopefully fix the recoll package issu= e.=20 It's at https://sourceware.org/git/?p=3Dlibabigail.git;a=3Dcommit;h=3D2b8b8bc5a8868= d3ab9eae487fa64b4d4374e5297. This should hopefully close this issue. Thanks! --=20 You are receiving this mail because: You are on the CC list for the bug.=