public inbox for libabigail@sourceware.org
 help / color / mirror / Atom feed
From: "dodji at redhat dot com" <sourceware-bugzilla@sourceware.org>
To: libabigail@sourceware.org
Subject: [Bug default/29302] xeres-c doesn't self compare
Date: Tue, 12 Jul 2022 16:00:57 +0000	[thread overview]
Message-ID: <bug-29302-9487-7TnwtxGWRZ@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-29302-9487@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=29302

dodji at redhat dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

--- Comment #4 from dodji at redhat dot com ---
(In reply to Ben Woodard from comment #3)
> The prototype patch seems to fix the problem with xerces-c,  qt-virt-manager
> 
> diff --git a/src/abg-dwarf-reader.cc b/src/abg-dwarf-reader.cc
> index 32a2cead..b71e94d7 100644
> --- a/src/abg-dwarf-reader.cc
> +++ b/src/abg-dwarf-reader.cc
> @@ -14987,7 +14987,7 @@ build_function_decl(read_context&	ctxt,
>  	  result->set_symbol(fn_sym);
>  	  string linkage_name = result->get_linkage_name();
>  	  if (linkage_name.empty()
> -	      || !fn_sym->get_alias_from_name(linkage_name))
> +	      /*|| !fn_sym->get_alias_from_name(linkage_name)*/)
>  	    result->set_linkage_name(fn_sym->get_name());
>  	  result->set_is_in_public_symbol_table(true);
>  	}

Cool!, thanks!

I have thus applied the patch at
https://sourceware.org/git/?p=libabigail.git;a=commit;h=e4c3d18aafbf94f48104f050cb1936a5e2ee5dcd.

> However it didn't seem to fix the problem with recoll which I would have
> classified in the same problem. I'm really not sure if that means that
> recoll has a different problem or if the solution is incomplete.

Hmmh, that issue (with the recoll package) seems to be different.  Let me look
into it.

> Let me know if you want to close this one and have me file another one or if
> you want to address both issues in this one bug report

I'll look into it.  If it needs to be qualified differently, I'll do it,
thanks!

-- 
You are receiving this mail because:
You are on the CC list for the bug.

  parent reply	other threads:[~2022-07-12 16:00 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-29 21:02 [Bug default/29302] New: " woodard at redhat dot com
2022-06-29 21:03 ` [Bug default/29302] " woodard at redhat dot com
2022-07-06 15:20 ` woodard at redhat dot com
2022-07-06 15:24 ` woodard at redhat dot com
2022-07-07 16:49 ` woodard at redhat dot com
2022-07-12 16:00 ` dodji at redhat dot com [this message]
2022-07-14 14:19 ` dodji at redhat dot com
2022-07-18 11:22 ` dodji at redhat dot com
2022-07-18 14:00 ` dodji at redhat dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-29302-9487-7TnwtxGWRZ@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=libabigail@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).