[Bug default/29345] New: abipkgdiff --self-check can't read its own file for dx-4.4.4-58.fc36.armv7hl.rpm

[Bug default/29345] New: abipkgdiff --self-check can't read its own file for dx-4.4.4-58.fc36.armv7hl.rpm

[woodard at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=29345

            Bug ID: 29345
           Summary: abipkgdiff --self-check can't read its own file for
                    dx-4.4.4-58.fc36.armv7hl.rpm
           Product: libabigail
           Version: unspecified
            Status: NEW
          Severity: minor
          Priority: P2
         Component: default
          Assignee: dodji at redhat dot com
          Reporter: woodard at redhat dot com
                CC: libabigail at sourceware dot org
  Target Milestone: ---

This one is not terribly important but it also looks like a trivial thing to
fix. For some reason, abipkgdiff seems to be truncating lines in its own abixml
file. The problem doesn't seem to happen on other architectures.

$ abipkgdiff --self-check  --d1
/home/ben/.cache/fedabipkgdiff/downloads/dx-debuginfo-4.4.4-58.fc36.armv7hl.rpm
/home/ben/.cache/fedabipkgdiff/downloads/dx-4.4.4-58.fc36.armv7hl.rpm | less
/home/ben/.cache/libabigail/abipkgdiff-tmp-dir-0oaQpN/package1/abixml/usr/lib/dx/bin_linux/tutor.abi:1015:
parser error : error parsing attribute name
root' type-id='type-id-2' visibility='default' filepath='/usr/include/X11/Xlib' 
                                                                              
^
/home/ben/.cache/libabigail/abipkgdiff-tmp-dir-0oaQpN/package1/abixml/usr/lib/dx/bin_linux/tutor.abi:1015:
parser error : attributes construct error
root' type-id='type-id-2' visibility='default' filepath='/usr/include/X11/Xlib' 
                                                                              
^
/home/ben/.cache/libabigail/abipkgdiff-tmp-dir-0oaQpN/package1/abixml/usr/lib/dx/bin_linux/tutor.abi:1015:
parser error : error parsing attribute name
root' type-id='type-id-2' visibility='default' filepath='/usr/include/X11/Xlib' 
                                                                              
^
/home/ben/.cache/libabigail/abipkgdiff-tmp-dir-0oaQpN/package1/abixml/usr/lib/dx/bin_linux/tutor.abi:1015:
parser error : attributes construct error
root' type-id='type-id-2' visibility='default' filepath='/usr/include/X11/Xlib' 
                                                                              
^
/home/ben/.cache/libabigail/abipkgdiff-tmp-dir-0oaQpN/package1/abixml/usr/lib/dx/bin_linux/tutor.abi:1015:
parser error : Couldn't find end of Start Tag var-decl
root' type-id='type-id-2' visibility='default' filepath='/usr/include/X11/Xlib' 
                                                                              
^
/home/ben/.cache/libabigail/abipkgdiff-tmp-dir-0oaQpN/package1/abixml/usr/lib/dx/bin_linux/tutor.abi:1015:
parser error : Couldn't find end of Start Tag var-decl
root' type-id='type-id-2' visibility='default' filepath='/usr/include/X11/Xlib' 
                                                                              
^
abipkgdiff: ../../../libabigail/src/abg-reader.cc:1488:
abigail::ir::type_base_sptr
abigail::xml_reader::read_context::build_or_get_type_decl(const std::string&,
bool): Assertion `__abg_cond__' failed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/29345] abipkgdiff --self-check can't read its own file for dx-4.4.4-58.fc36.armv7hl.rpm

[woodard at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=29345

--- Comment #1 from Ben Woodard <woodard at redhat dot com> ---
This continues to reproduce with trunk as of
df28c220976f41620b0bd7b22000815e11f66b75

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/29345] abipkgdiff --self-check can't read its own file for dx-4.4.4-58.fc36.armv7hl.rpm

[woodard at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=29345

Ben Woodard <woodard at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |29412


Referenced Bugs:

https://sourceware.org/bugzilla/show_bug.cgi?id=29412
[Bug 29412] Assertion metabug
-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/29345] abipkgdiff --self-check can't read its own file for dx-4.4.4-58.fc36.armv7hl.rpm

[woodard at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=29345

--- Comment #2 from Ben Woodard <woodard at redhat dot com> ---
There is a very similar assert from java-11-openjdk-headless

/home/ben/.cache/libabigail/abipkgdiff-tmp-dir-RDaFWX/package1/abixml/usr/lib/jvm/java-11-openjdk-11.0.16.0.8-1.fc36.aarch64/lib/jexec.abi:1:
parser error : Extra content at the end of the document

^
/home/ben/.cache/libabigail/abipkgdiff-tmp-dir-RDaFWX/package1/abixml/usr/lib/jvm/java-11-openjdk-11.0.16.0.8-1.fc36.aarch64/bin/jjs.abi:1:
parser error : Extra content at the end of the document

^
/home/ben/.cache/libabigail/abipkgdiff-tmp-dir-RDaFWX/package1/abixml/usr/lib/jvm/java-11-openjdk-11.0.16.0.8-1.fc36.aarch64/lib/jspawnhelper.abi:1:
parser error : Extra content at the end of the document

^
/home/ben/.cache/libabigail/abipkgdiff-tmp-dir-RDaFWX/package1/abixml/usr/lib/jvm/java-11-openjdk-11.0.16.0.8-1.fc36.aarch64/bin/rmiregistry.abi:1:
parser error : Extra content at the end of the document

^
/home/ben/.cache/libabigail/abipkgdiff-tmp-dir-RDaFWX/package1/abixml/usr/lib/jvm/java-11-openjdk-11.0.16.0.8-1.fc36.aarch64/bin/keytool.abi:1:
parser error : Extra content at the end of the document

^
/home/ben/.cache/libabigail/abipkgdiff-tmp-dir-RDaFWX/package1/abixml/usr/lib/jvm/java-11-openjdk-11.0.16.0.8-1.fc36.aarch64/bin/pack200.abi:1:
parser error : Extra content at the end of the document

^
/home/ben/.cache/libabigail/abipkgdiff-tmp-dir-RDaFWX/package1/abixml/usr/lib/jvm/java-11-openjdk-11.0.16.0.8-1.fc36.aarch64/bin/alt-java.abi:1:
parser error : Extra content at the end of the document

^
/home/ben/.cache/libabigail/abipkgdiff-tmp-dir-RDaFWX/package1/abixml/usr/lib/jvm/java-11-openjdk-11.0.16.0.8-1.fc36.aarch64/bin/java.abi:1:
parser error : Extra content at the end of the document

^

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/29345] abipkgdiff --self-check can't read its own file for dx-4.4.4-58.fc36.armv7hl.rpm

[woodard at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=29345

--- Comment #3 from Ben Woodard <woodard at redhat dot com> ---
This continues to be a problem with the latest 2.1

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/29345] abipkgdiff --self-check can't read its own file for dx-4.4.4-58.fc36.armv7hl.rpm

[woodard at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=29345

--- Comment #4 from Ben Woodard <woodard at redhat dot com> ---
continues to reproduce with the current trunk as of:

commit a8a4ca8862959e9fede1b4878469681b8fadeb74 (HEAD -> master, origin/master,
origin/HEAD)
Author: Dodji Seketeli <dodji@redhat.com>
Date:   Wed Mar 22 15:42:43 2023 +0100

    abipkgdiff: Fix a typo

            * tools/abipkgdiff.cc (compare_to_self): Fix a typo.

    Signed-off-by: Dodji Seketeli <dodji@redhat.com>

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/29345] abipkgdiff is confused by symlinked binaries in RPMs

[dodji at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=29345

dodji at redhat dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|abipkgdiff --self-check     |abipkgdiff is confused by
                   |can't read its own file for |symlinked binaries in RPMs
                   |dx-4.4.4-58.fc36.armv7hl.rp |
                   |m                           |

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/29345] abipkgdiff is confused by symlinked binaries in RPMs

[dodji at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=29345

dodji at redhat dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #5 from dodji at redhat dot com ---
This one should be fixed by commit
https://sourceware.org/git/?p=libabigail.git;a=commit;h=7952a748de3578964b2c6b8d3bb94e0bbcfb653e.
 That fix should be available in libabigail 2.3.

Thank you for reporting this issue and sorry for the inconvenience.

-- 
You are receiving this mail because:
You are on the CC list for the bug.