public inbox for libabigail@sourceware.org
 help / color / mirror / Atom feed
* [Bug default/29360] New: Ada ranges emitting/reading/diffing are not supported in libabigail
@ 2022-07-12 15:50 dodji at redhat dot com
  2022-07-12 15:55 ` [Bug default/29360] " dodji at redhat dot com
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: dodji at redhat dot com @ 2022-07-12 15:50 UTC (permalink / raw)
  To: libabigail

https://sourceware.org/bugzilla/show_bug.cgi?id=29360

            Bug ID: 29360
           Summary: Ada ranges emitting/reading/diffing are not supported
                    in libabigail
           Product: libabigail
           Version: unspecified
            Status: NEW
          Severity: enhancement
          Priority: P2
         Component: default
          Assignee: dodji at redhat dot com
          Reporter: dodji at redhat dot com
                CC: libabigail at sourceware dot org
  Target Milestone: ---

fedabipkgdiff --self-compare -a --from fc36 zlib-ada

Appears to be stuck.  Upon closer look it appears that abipkgdiff is stuck in
an infinite loop:

build/tools/abipkgdiff --self-check  --d1
/home/dodji/.cache/fedabipkgdiff/downloads/zlib-ada-debuginfo-1.4-0.30.20120830CVS.fc36.x86_64.rpm
/home/dodji/.cache/fedabipkgdiff/downloads/zlib-ada-1.4-0.30.20120830CVS.fc36.x86_64.rpm
.


Free form range types (range types that are not part of array types), used in
Ada are not fully supported by Libabigail.

What is not supported is their serilization in abixml, their de-serialization
from abixml and their comparison by the comparison engine.

I started a branch with that work, at
https://sourceware.org/git/?p=libabigail.git;a=shortlog;h=refs/heads/free-range-types.

What needs to be done is the support for diffing.  Basically, creating a diff
type for range types, coming up with a compute_diff function that takes ranges
and returns the diff type for ranges and adding support for reporting the
changes carried by the range diff type.

This is a nice little feature to work on, IMHO.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug default/29360] Ada ranges emitting/reading/diffing are not supported in libabigail
  2022-07-12 15:50 [Bug default/29360] New: Ada ranges emitting/reading/diffing are not supported in libabigail dodji at redhat dot com
@ 2022-07-12 15:55 ` dodji at redhat dot com
  2023-04-06 11:20 ` dodji at redhat dot com
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: dodji at redhat dot com @ 2022-07-12 15:55 UTC (permalink / raw)
  To: libabigail

https://sourceware.org/bugzilla/show_bug.cgi?id=29360

dodji at redhat dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |29303


Referenced Bugs:

https://sourceware.org/bugzilla/show_bug.cgi?id=29303
[Bug 29303] Unacceptable performance doing fedabipkgdiff on some packages
-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug default/29360] Ada ranges emitting/reading/diffing are not supported in libabigail
  2022-07-12 15:50 [Bug default/29360] New: Ada ranges emitting/reading/diffing are not supported in libabigail dodji at redhat dot com
  2022-07-12 15:55 ` [Bug default/29360] " dodji at redhat dot com
@ 2023-04-06 11:20 ` dodji at redhat dot com
  2023-04-06 11:21 ` dodji at redhat dot com
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: dodji at redhat dot com @ 2023-04-06 11:20 UTC (permalink / raw)
  To: libabigail

https://sourceware.org/bugzilla/show_bug.cgi?id=29360

dodji at redhat dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |29333


Referenced Bugs:

https://sourceware.org/bugzilla/show_bug.cgi?id=29333
[Bug 29333] fedabipkgdiff --self-compare asserts on Gtk3Ada and Gtk3Ada
-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug default/29360] Ada ranges emitting/reading/diffing are not supported in libabigail
  2022-07-12 15:50 [Bug default/29360] New: Ada ranges emitting/reading/diffing are not supported in libabigail dodji at redhat dot com
  2022-07-12 15:55 ` [Bug default/29360] " dodji at redhat dot com
  2023-04-06 11:20 ` dodji at redhat dot com
@ 2023-04-06 11:21 ` dodji at redhat dot com
  2023-04-07 18:16 ` dodji at redhat dot com
  2023-04-07 18:17 ` dodji at redhat dot com
  4 siblings, 0 replies; 6+ messages in thread
From: dodji at redhat dot com @ 2023-04-06 11:21 UTC (permalink / raw)
  To: libabigail

https://sourceware.org/bugzilla/show_bug.cgi?id=29360

dodji at redhat dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |29333
             Blocks|29303, 29333                |


Referenced Bugs:

https://sourceware.org/bugzilla/show_bug.cgi?id=29303
[Bug 29303] Unacceptable performance doing fedabipkgdiff on some packages
https://sourceware.org/bugzilla/show_bug.cgi?id=29333
[Bug 29333] fedabipkgdiff --self-compare asserts on Gtk3Ada and Gtk3Ada
-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug default/29360] Ada ranges emitting/reading/diffing are not supported in libabigail
  2022-07-12 15:50 [Bug default/29360] New: Ada ranges emitting/reading/diffing are not supported in libabigail dodji at redhat dot com
                   ` (2 preceding siblings ...)
  2023-04-06 11:21 ` dodji at redhat dot com
@ 2023-04-07 18:16 ` dodji at redhat dot com
  2023-04-07 18:17 ` dodji at redhat dot com
  4 siblings, 0 replies; 6+ messages in thread
From: dodji at redhat dot com @ 2023-04-07 18:16 UTC (permalink / raw)
  To: libabigail

https://sourceware.org/bugzilla/show_bug.cgi?id=29360
Bug 29360 depends on bug 29333, which changed state.

Bug 29333 Summary: fedabipkgdiff --self-compare asserts on Gtk3Ada and Gtk3Ada
https://sourceware.org/bugzilla/show_bug.cgi?id=29333

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug default/29360] Ada ranges emitting/reading/diffing are not supported in libabigail
  2022-07-12 15:50 [Bug default/29360] New: Ada ranges emitting/reading/diffing are not supported in libabigail dodji at redhat dot com
                   ` (3 preceding siblings ...)
  2023-04-07 18:16 ` dodji at redhat dot com
@ 2023-04-07 18:17 ` dodji at redhat dot com
  4 siblings, 0 replies; 6+ messages in thread
From: dodji at redhat dot com @ 2023-04-07 18:17 UTC (permalink / raw)
  To: libabigail

https://sourceware.org/bugzilla/show_bug.cgi?id=29360

dodji at redhat dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #1 from dodji at redhat dot com ---
It looks like this support for Ada ranges is now in.

At least from this patch:

ff8cba87 dwarf-reader: Support indirectly referenced subrange_type DIEs

I am thus closing this bug now.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2023-04-07 18:17 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-12 15:50 [Bug default/29360] New: Ada ranges emitting/reading/diffing are not supported in libabigail dodji at redhat dot com
2022-07-12 15:55 ` [Bug default/29360] " dodji at redhat dot com
2023-04-06 11:20 ` dodji at redhat dot com
2023-04-06 11:21 ` dodji at redhat dot com
2023-04-07 18:16 ` dodji at redhat dot com
2023-04-07 18:17 ` dodji at redhat dot com

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).