From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id 6DA753857001; Mon, 8 Aug 2022 17:23:17 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6DA753857001 From: "gprocida at google dot com" To: libabigail@sourceware.org Subject: [Bug default/29458] New: abidw considers (some) function-local types to belong to the wrong scope Date: Mon, 08 Aug 2022 17:23:17 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: libabigail X-Bugzilla-Component: default X-Bugzilla-Version: unspecified X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: gprocida at google dot com X-Bugzilla-Status: UNCONFIRMED X-Bugzilla-Resolution: X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: dodji at redhat dot com X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version bug_status bug_severity priority component assigned_to reporter cc target_milestone Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Aug 2022 17:23:17 -0000 https://sourceware.org/bugzilla/show_bug.cgi?id=3D29458 Bug ID: 29458 Summary: abidw considers (some) function-local types to belong to the wrong scope Product: libabigail Version: unspecified Status: UNCONFIRMED Severity: normal Priority: P2 Component: default Assignee: dodji at redhat dot com Reporter: gprocida at google dot com CC: libabigail at sourceware dot org Target Milestone: --- I was looking at commit df28c220976f41620b0bd7b22000815e11f66b75 (current master) and the update to the test files there showed an interesting change. There are multiple vtkPixelTransfer::VTK_TT typedefs in the ABI. However, b= oth dwarfdump and the original source code show that VTK_TT is a function-local (actually block-local) type. Source: https://github.com/Kitware/VTK/blob/master/Common/Core/vtkSetGet.h#L1064 This suggests that libabigail is attributing the type to the wrong scope. However, with all the macro and template magic going on, it's hard to be 10= 0% certain. --=20 You are receiving this mail because: You are on the CC list for the bug.=