From: "dodji at redhat dot com" <sourceware-bugzilla@sourceware.org>
To: libabigail@sourceware.org
Subject: [Bug default/29464] abidw performance regression on vmlinux
Date: Thu, 01 Sep 2022 09:03:53 +0000 [thread overview]
Message-ID: <bug-29464-9487-7yr0RuHwf4@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-29464-9487@http.sourceware.org/bugzilla/>
https://sourceware.org/bugzilla/show_bug.cgi?id=29464
--- Comment #2 from dodji at redhat dot com ---
(In reply to gprocida from comment #1)
> The performance regression is reproducible with this test case:
>
> https://github.com/myxoid/libabigail/raw/
> 51fd7ce8d9b896bf4736bb638266bda5c761ee8a/vmlinux.lzma
Thank you Giuliano, this was very useful. I could reproduce the issue, indeed.
The issue comes from the fixing of the earlier canonical propagation during the
computing of canonical type DIEs, when canonicalizing type DIEs.
Before 7ecef6361799326b99129a479b43b138f0b237ae, we were propagating canonical
DIEs "too much". Things were fast. But wrong. That is why I tried to fix the
issue. But then, it appears that with that fix, we are not propagating
canonical DIEs "enough", so things are super slow.
I have a tentative approach to this in the branch
users/dodji/libabigail-perf-regr, accessible at
https://sourceware.org/git/?p=libabigail.git;a=shortlog;h=refs/heads/users/dodji/libabigail-perf-regr.
It should bring things back to an acceptable performance, albeit slower to what
it was previously (probably in the 35s range for you).
I still need to comment and split the content into proper patches but you can
already test it to see if things work for you with that branch.
In the mean time, I am moving forward with the commenting & splitting.
--
You are receiving this mail because:
You are on the CC list for the bug.
next prev parent reply other threads:[~2022-09-01 9:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-09 17:57 [Bug default/29464] New: " gprocida at google dot com
2022-08-10 15:05 ` [Bug default/29464] " gprocida at google dot com
2022-08-22 9:37 ` dodji at redhat dot com
2022-09-01 9:03 ` dodji at redhat dot com [this message]
2022-09-06 16:00 ` gprocida at google dot com
2022-09-06 16:10 ` gprocida at google dot com
2022-09-06 16:37 ` gprocida at google dot com
2022-09-08 9:28 ` gprocida at google dot com
2022-09-19 10:19 ` dodji at redhat dot com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-29464-9487-7yr0RuHwf4@http.sourceware.org/bugzilla/ \
--to=sourceware-bugzilla@sourceware.org \
--cc=libabigail@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).