From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id 3390E385355A; Tue, 6 Sep 2022 16:00:26 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3390E385355A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1662480026; bh=8yjeanBH7H4u4avAL8zB7mzl4+ibG8lYQjgaAt9Ogdo=; h=From:To:Subject:Date:In-Reply-To:References:From; b=isEw+42mD3Z+8S7s7hAFJ6uGWS3JVepV0PlBzZTHwwGNDtotnY6WJAmqkdxG6e/Iw XVku9tRABAJgVxieVNOYgjMUdu+DM4bEhreQu3qxxiCbvXg54Oq/AQKr+6a5oB52ya jsN2BVKNClmsp9tSxIMNumIvZ+VaDI+IuKYdQ+x4= From: "gprocida at google dot com" To: libabigail@sourceware.org Subject: [Bug default/29464] abidw performance regression on vmlinux Date: Tue, 06 Sep 2022 16:00:25 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: libabigail X-Bugzilla-Component: default X-Bugzilla-Version: unspecified X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: gprocida at google dot com X-Bugzilla-Status: ASSIGNED X-Bugzilla-Resolution: X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: dodji at redhat dot com X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 List-Id: https://sourceware.org/bugzilla/show_bug.cgi?id=3D29464 --- Comment #3 from gprocida at google dot com --- Hi Dodji. I have done some tests by merging dodji-perf (e6f222c8) into AOSP and runni= ng our tests. In more detail: I noticed that there was a merge conflict of "dwarf-reader: Revamp the canonical type DIE propagation algorithm" with my hack that limited compari= sons per DIE pair to 10000. Given it seemed that the changes were working in the same area, I reverted my hack and remerged. I ran into trouble as your development branch is not known to AOSP, so I actually ended up with: revert, merge, cherry-pick x 2. I need to retest without any AOSP things. However, here is some initial feedback: 1. Testing (unintentionally) at the second last cherry-pick ("dwarf-reader: Revamp the canonical type DIE propagation algorithm") showed some test time= outs on our standard kernel tests. This means I cannot push that series to AOSP. I will consider reinstating my hack and trying again, after other tests. The test suite run also shows other issues: * name changes like "long long unsigned" to "unsigned long long int" * linearly probed - and so unstable - hash-based type ids for types like "unsigned int" and "unsigned short int" (the strings that get hashed are the same for the different types) The last of these issues will also need to be resolved - we may decide to d= o it in post-processing, but I imagine it's only a small change in libabigail. 2. Testing at the last cherry-pick ("Allow restricting analyzed decls to exported symbols") also had test timeouts. However, more seriously, the run time (for a 4.19 kernel) is much worse than in 1. I haven't yet done any ABI comparisons using this abidw's output as it still running at over 30 minutes. --=20 You are receiving this mail because: You are on the CC list for the bug.=