From: "gprocida at google dot com" <sourceware-bugzilla@sourceware.org>
To: libabigail@sourceware.org
Subject: [Bug default/29464] New: abidw performance regression on vmlinux
Date: Tue, 09 Aug 2022 17:57:50 +0000 [thread overview]
Message-ID: <bug-29464-9487@http.sourceware.org/bugzilla/> (raw)
https://sourceware.org/bugzilla/show_bug.cgi?id=29464
Bug ID: 29464
Summary: abidw performance regression on vmlinux
Product: libabigail
Version: unspecified
Status: UNCONFIRMED
Severity: normal
Priority: P2
Component: default
Assignee: dodji at redhat dot com
Reporter: gprocida at google dot com
CC: libabigail at sourceware dot org
Target Milestone: ---
Hi Dodji.
I've been testing changes since our last upstream merge and have found a
performance regression.
A typical standalone "abidw vmlinux" normally takes around 20s on an AOSP
kernel. Following the merge, run times are around 1.5h. So that's around 270
times slower.
Using almost vanilla upstream libabigail (I had to disable one ELF symbol
assertion for unrelated reasons), I was able to bisect the regression to:
7ecef6361799326b99129a479b43b138f0b237ae "Canonicalize DIEs w/o assuming ODR &
handle typedefs transparently"
This commit does a few things, but most significantly removes an optimisation
that assumed the ODR.
The change in behaviour was consistent across 6 different test kernels and a
couple of other kernels I had lying around from different test cases. However,
in one case, abidw ran quickly as normal.
It's very likely that one of the previous kernels you've had from me will
trigger the problem. I will also see if I can find "off the shelf" binary that
you can debug with.
Regards,
Giuliano.
--
You are receiving this mail because:
You are on the CC list for the bug.
next reply other threads:[~2022-08-09 17:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-09 17:57 gprocida at google dot com [this message]
2022-08-10 15:05 ` [Bug default/29464] " gprocida at google dot com
2022-08-22 9:37 ` dodji at redhat dot com
2022-09-01 9:03 ` dodji at redhat dot com
2022-09-06 16:00 ` gprocida at google dot com
2022-09-06 16:10 ` gprocida at google dot com
2022-09-06 16:37 ` gprocida at google dot com
2022-09-08 9:28 ` gprocida at google dot com
2022-09-19 10:19 ` dodji at redhat dot com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-29464-9487@http.sourceware.org/bugzilla/ \
--to=sourceware-bugzilla@sourceware.org \
--cc=libabigail@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).