From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id 7C7DC38A8161; Tue, 13 Sep 2022 10:36:40 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7C7DC38A8161 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1663065400; bh=84Ftyw00o2kItEB9T2HPlnDeOdH/KiNFMgHKG2w7eso=; h=From:To:Subject:Date:From; b=FLTgw3xAUSJB2TcFTaxMC2cPe/txH2ambfGJn4c6p7FSlOto90VT715uIKvB1Rkyn M49YdarPzu2yO3fkhqfYZP2hcqb9fU+LoXgMfGJzF1v0GtBw/unSKh6wXLGQGVfCWB yj7kwmZrfrjr2btGkOlRZtmk1ObzpUJndD5ezC8c= From: "gprocida at google dot com" To: libabigail@sourceware.org Subject: [Bug default/29568] New: abidiff - misses diffs in highly connected ABI Date: Tue, 13 Sep 2022 10:36:39 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: libabigail X-Bugzilla-Component: default X-Bugzilla-Version: unspecified X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: gprocida at google dot com X-Bugzilla-Status: UNCONFIRMED X-Bugzilla-Resolution: X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: dodji at redhat dot com X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version bug_status bug_severity priority component assigned_to reporter cc target_milestone attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 List-Id: https://sourceware.org/bugzilla/show_bug.cgi?id=3D29568 Bug ID: 29568 Summary: abidiff - misses diffs in highly connected ABI Product: libabigail Version: unspecified Status: UNCONFIRMED Severity: normal Priority: P2 Component: default Assignee: dodji at redhat dot com Reporter: gprocida at google dot com CC: libabigail at sourceware dot org Target Milestone: --- Created attachment 14332 --> https://sourceware.org/bugzilla/attachment.cgi?id=3D14332&action=3Ded= it test case files Hi Dodji. While doing some performance tests, I found an abidiff issue (with an older version of libabigail). The attached test case includes two XML files which are almost but not quite identical. I've written up the reproducible test case as a script (though there is a chance that type ids won't quite match match what sed expects depending on = the exact build of abidw). In any case you can examine and diff the XML files "= by hand". abidiff should report a diff but does not. --harmless makes no difference. I'm not sure if the "connectedness" of the ABIs is significant. This "old" abidiff performance is fine here, BTW, but current libabigail is very slow. So you could also use this example for performance testing abidi= ff. I don't actually know how long it takes to run as it's still running as I t= ype this. I suppose it's possible that current libabigail does find the diff...= in which case this is a performance bug instead. I'll follow up if/when it terminates. Regards, Giuliano. --=20 You are receiving this mail because: You are on the CC list for the bug.=