[Bug default/29693] New: clang-libs from f37 fails self test with 2.1

[Bug default/29693] New: clang-libs from f37 fails self test with 2.1

[woodard at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=29693

            Bug ID: 29693
           Summary: clang-libs from f37 fails self test with 2.1
           Product: libabigail
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: default
          Assignee: dodji at redhat dot com
          Reporter: woodard at redhat dot com
                CC: libabigail at sourceware dot org
  Target Milestone: ---

This is an interesting one because it is both an assert and a bad comparison.
It also doesn't seem to fall in with any of the other bad comparisons or
asserts.

The impacted library is libclang-cpp.so.15 so this is a library issue.


$ fedabipkgdiff --self-compare -a --from fc37 clang-libs
Comparing the ABI of binaries between clang-libs-15.0.0-2.fc37.aarch64.rpm and
clang-libs-15.0.0-2.fc37.aarch64.rpm:

======== comparing'libclang-cpp.so.15' to itself wrongly yielded result:
===========
  Functions changes summary: 0 Removed, 1 Changed (1 filtered out), 0 Added
functions
  Variables changes summary: 0 Removed, 0 Changed, 0 Added variable

  1 function with some indirect sub-type change:

    [C] 'method virtual clang::dataflow::Solver::Result
clang::dataflow::WatchedLiteralsSolver::solve(llvm::DenseSet<clang::dataflow::BoolValue
*, llvm::DenseMapInfo<clang::dataflow::BoolValue *, void> >)' at
WatchedLiteralsSolver.h:31:1 has some indirect sub-type changes:
      return type changed:
        type size hasn't changed
        2 data member deletions:
          'clang::dataflow::Solver::Result::Status SATCheckStatus', at offset 0
(in bits) at Solver.h:78:1
          'llvm::Optional<llvm::DenseMap<clang::dataflow::AtomicBoolValue *,
clang::dataflow::Solver::Result::Assignment,
llvm::DenseMapInfo<clang::dataflow::AtomicBoolValue *, void>,
llvm::detail::DenseMapPair<clang::dataflow::AtomicBoolValue *,
clang::dataflow::Solver::Result::Assignment> > > Solution', at offset 64 (in
bits) at Solver.h:79:1

===SELF CHECK FAILED for 'libclang-cpp.so.15'
==== SELF CHECK SUCCEEDED for 'libclang.so.15.0.0' ====

Comparing the ABI of binaries between clang-devel-15.0.0-2.fc37.aarch64.rpm and
clang-devel-15.0.0-2.fc37.aarch64.rpm:

==== SELF CHECK SUCCEEDED for 'clang-tblgen' ====

Comparing the ABI of binaries between clang-libs-15.0.0-2.fc37.i686.rpm and
clang-libs-15.0.0-2.fc37.i686.rpm:

==== SELF CHECK SUCCEEDED for 'libclang-cpp.so.15' ====
==== SELF CHECK SUCCEEDED for 'libclang.so.15.0.0' ====

Comparing the ABI of binaries between clang-devel-15.0.0-2.fc37.i686.rpm and
clang-devel-15.0.0-2.fc37.i686.rpm:

==== SELF CHECK SUCCEEDED for 'clang-tblgen' ====

Comparing the ABI of binaries between clang-libs-15.0.0-2.fc37.ppc64le.rpm and
clang-libs-15.0.0-2.fc37.ppc64le.rpm:

==== SELF CHECK SUCCEEDED for 'libclang-cpp.so.15' ====
==== SELF CHECK SUCCEEDED for 'libclang.so.15.0.0' ====

Comparing the ABI of binaries between clang-devel-15.0.0-2.fc37.ppc64le.rpm and
clang-devel-15.0.0-2.fc37.ppc64le.rpm:

==== SELF CHECK SUCCEEDED for 'clang-tblgen' ====

Comparing the ABI of binaries between clang-libs-15.0.0-2.fc37.s390x.rpm and
clang-libs-15.0.0-2.fc37.s390x.rpm:

==== SELF CHECK SUCCEEDED for 'libclang-cpp.so.15' ====
==== SELF CHECK SUCCEEDED for 'libclang.so.15.0.0' ====

Comparing the ABI of binaries between clang-devel-15.0.0-2.fc37.s390x.rpm and
clang-devel-15.0.0-2.fc37.s390x.rpm:

==== SELF CHECK SUCCEEDED for 'clang-tblgen' ====

Comparing the ABI of binaries between clang-devel-15.0.0-2.fc37.x86_64.rpm and
clang-devel-15.0.0-2.fc37.x86_64.rpm:

==== SELF CHECK SUCCEEDED for 'clang-tblgen' ====

Comparing the ABI of binaries between clang-libs-15.0.0-2.fc37.x86_64.rpm and
clang-libs-15.0.0-2.fc37.x86_64.rpm:

abipkgdiff: ../../../libabigail/src/abg-default-reporter.cc:375: virtual void
abigail::comparison::default_reporter::report(const
abigail::comparison::qualified_type_diff&, std::ostream&, const std::string&)
const: Assertion `__abg_cond__' failed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/29693] clang-libs from f37 fails self test with 2.1

[woodard at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=29693

Ben Woodard <woodard at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |29412, 29413


Referenced Bugs:

https://sourceware.org/bugzilla/show_bug.cgi?id=29412
[Bug 29412] libabigail 2.1.1 Assertion metabug
https://sourceware.org/bugzilla/show_bug.cgi?id=29413
[Bug 29413] libabigail 2.1.1 self-compare metabug
-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/29693] clang-libs from f37 fails self test with 2.1

[woodard at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=29693

Ben Woodard <woodard at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |critical

--- Comment #1 from Ben Woodard <woodard at redhat dot com> ---
Tom Stellard:

I have wanted to use libabigail for checking the ABI of libLLVM.so and
libclang-cpp.so, but it takes way too much memory (IIRC >32GB).
Optimizing libabigail to work better with these libraries
would allow us to actually use this tool check our RPM updates.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/29693] clang-libs from f37 fails self test with 2.1

[woodard at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=29693

--- Comment #2 from Ben Woodard <woodard at redhat dot com> ---
This continues to reproduce with the latest trunk as of: 

commit a8a4ca8862959e9fede1b4878469681b8fadeb74 (HEAD -> master, origin/master,
origin/HEAD)
Author: Dodji Seketeli <dodji@redhat.com>
Date:   Wed Mar 22 15:42:43 2023 +0100

    abipkgdiff: Fix a typo

            * tools/abipkgdiff.cc (compare_to_self): Fix a typo.

    Signed-off-by: Dodji Seketeli <dodji@redhat.com>

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/29693] clang-libs from f37 fails self test with 2.1

[woodard at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=29693

--- Comment #3 from Ben Woodard <woodard at redhat dot com> ---
This one seems to be behaving oddly. Most other fedabipkgdiff launch abipkgdiff
and you can see the amount of memory shoot up as it consumes the corpus. Then
that finishes and it moves onto the next package and finally terminates.

clang-libs did that but the python code in fedabipkgdiff seemed to get stuck in
a tight loop after the abipkgdiffs ran and it just continues running at 100%
CPU but I don't think it is doing much real work because it is only using 0.1%
of memory. So I think something is going wrong in the fedabipkgdiff python.

This is with the current trunk as of:

commit a8a4ca8862959e9fede1b4878469681b8fadeb74 (HEAD -> master, origin/master,
origin/HEAD)
Author: Dodji Seketeli <dodji@redhat.com>
Date:   Wed Mar 22 15:42:43 2023 +0100

    abipkgdiff: Fix a typo

            * tools/abipkgdiff.cc (compare_to_self): Fix a typo.

    Signed-off-by: Dodji Seketeli <dodji@redhat.com>

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/29693] clang-libs from f37 fails self test with 2.1

[woodard at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=29693

--- Comment #4 from Ben Woodard <woodard at redhat dot com> ---
The fedabipkgdiff on clang-libs ran all night without making any apparent
forward progress. So it appears like we have two bugs here.

1) what is causing fedabipkgdiff to spin in what appears to be an infinite loop
after doing  at least some of the abipkgdiff comparisons.

2) clang-libs is failing selfcheck when run at a basic abipkgdiff level.


$ abipkgdiff --self-check  --d1
/home/ben/.cache/fedabipkgdiff/downloads/clang-devel-debuginfo-15.0.7-2.fc37.aarch64.rpm
 --d1
/home/ben/.cache/fedabipkgdiff/downloads/clang-libs-debuginfo-15.0.7-2.fc37.aarch64.rpm
 --d1
/home/ben/.cache/fedabipkgdiff/downloads/clang-tools-extra-debuginfo-15.0.7-2.fc37.aarch64.rpm
 --d1
/home/ben/.cache/fedabipkgdiff/downloads/clang-debuginfo-15.0.7-2.fc37.aarch64.rpm
/home/ben/.cache/fedabipkgdiff/downloads/clang-libs-15.0.7-2.fc37.aarch64.rpm
======== comparing'libclang-cpp.so.15' to itself wrongly yielded result:
===========
  Functions changes summary: 0 Removed, 1 Changed (1 filtered out), 0 Added
functions
  Variables changes summary: 0 Removed, 0 Changed, 0 Added variable

  1 function with some indirect sub-type change:

    [C] 'method virtual clang::dataflow::Solver::Result
clang::dataflow::WatchedLiteralsSolver::solve(llvm::DenseSet<clang::dataflow::BoolValue
*, llvm::DenseMapInfo<clang::dataflow::BoolValue *, void> >)' at
WatchedLiteralsSolver.h:31:1 has some indirect sub-type changes:
      return type changed:
        type size hasn't changed
        2 data member deletions:
          'clang::dataflow::Solver::Result::Status SATCheckStatus', at offset 0
(in bits) at Solver.h:78:1
          'llvm::Optional<llvm::DenseMap<clang::dataflow::AtomicBoolValue *,
clang::dataflow::Solver::Result::Assignment,
llvm::DenseMapInfo<clang::dataflow::AtomicBoolValue *, void>,
llvm::detail::DenseMapPair<clang::dataflow::AtomicBoolValue *,
clang::dataflow::Solver::Result::Assignment> > > Solution', at offset 64 (in
bits) at Solver.h:79:1

===SELF CHECK FAILED for 'libclang-cpp.so.15'
==== SELF CHECK SUCCEEDED for 'libclang.so.15.0.7' ====

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/29693] clang-libs from f37 fails self test with pre-2.3 trunk

[woodard at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=29693

Ben Woodard <woodard at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|clang-libs from f37 fails   |clang-libs from f37 fails
                   |self test with 2.1          |self test with pre-2.3
                   |                            |trunk

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/29693] clang-libs from f37 fails self test with pre-2.3 trunk

[dodji at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=29693

dodji at redhat dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|29412                       |


Referenced Bugs:

https://sourceware.org/bugzilla/show_bug.cgi?id=29412
[Bug 29412] libabigail 2.2 Assertion metabug
-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/29693] clang-libs from f37 fails self test with pre-2.3 trunk

[dodji at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=29693

dodji at redhat dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #5 from dodji at redhat dot com ---
This issue should now be solved by commit
https://sourceware.org/git/?p=libabigail.git;a=commit;h=06e8d54d0404ccf2a103804ec568797822152b69,
applied to the master branch. This fix should be available in the 2.4 version
of libabigail.

Thank you for taking the time to file this issue and sorry for the
inconvenience.

-- 
You are receiving this mail because:
You are on the CC list for the bug.