From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id BFEA43858D35; Thu, 1 Dec 2022 11:09:14 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BFEA43858D35 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1669892954; bh=Fe1dFBe3Zjv1M2B0uUeqHNuBw+LjacRLewp0EhlMMP0=; h=From:To:Subject:Date:In-Reply-To:References:From; b=k1sn69AHtgsc2BdhuPu3+kjA0An7dODqq9GBw3P7DlGv/y56rD9JmZgjxutrhM3E2 bGzPsi5d84A+3h7o8eeSjW4AyE8fJsnCIA9dVLmAkG2XC/Id0niHH+XN2YZffGfcZW cR6TdQM8TLRzyAAIqdDzhc4voFT4HK0/2dcq7LAo= From: "dodji at redhat dot com" To: libabigail@sourceware.org Subject: [Bug default/29733] Comparing 2.0 dump to 2.1 dump: parameter 1 of type 'int' was added to destructor Date: Thu, 01 Dec 2022 11:09:14 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: libabigail X-Bugzilla-Component: default X-Bugzilla-Version: unspecified X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: dodji at redhat dot com X-Bugzilla-Status: RESOLVED X-Bugzilla-Resolution: NOTABUG X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: dodji at redhat dot com X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: resolution bug_status Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 List-Id: https://sourceware.org/bugzilla/show_bug.cgi?id=3D29733 dodji at redhat dot com changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |NOTABUG Status|UNCONFIRMED |RESOLVED --- Comment #3 from dodji at redhat dot com --- Hello, I think the behaviour you are seeing is due to this commit that happened in= the 2.1 version, indeed: https://sourceware.org/git/?p=3Dlibabigail.git;a=3Dcommit;h=3D861e4670b611b= 2f95d69f68bb1edaa15ab5f3aa5. Long story short, that commit introduced a (minor) incompatibility in the a= bi dumps due to a fix in the handling of cloned functions. Cloned functions is how some compilers (like GCC) handle the implementation of the different ki= nds of destructor functions. With that fix, libabigail better represents all cloned functions in its IR. That is why you are seeing more destructors in = the ABI dump. I bumped the version number of ABIXML to say that users, like yourself, who rely on abi dumps need to re-generate those dumps with the new version of libabigail if they want to perform comparisons of the dumps, as opposed to comparing the binaries directly. So, long story even shorter, I think the solution would be to regenerate the dumps with the 2.1 version. I try to avoid those abixml version bumps, but sometimes they are necessary, sadly. Sorry for the inconvenience. --=20 You are receiving this mail because: You are on the CC list for the bug.=