[Bug default/29932] New: abidiff coredump at abg-ir.cc:hash_as_canonical_type_or_constant when read libc.so from glibc

[Bug default/29932] New: abidiff coredump at abg-ir.cc:hash_as_canonical_type_or_constant when read libc.so from glibc

[hexiaole1994 at 126 dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=29932

            Bug ID: 29932
           Summary: abidiff coredump at
                    abg-ir.cc:hash_as_canonical_type_or_constant when read
                    libc.so from glibc
           Product: libabigail
           Version: unspecified
            Status: UNCONFIRMED
          Severity: critical
          Priority: P2
         Component: default
          Assignee: dodji at redhat dot com
          Reporter: hexiaole1994 at 126 dot com
                CC: libabigail at sourceware dot org
  Target Milestone: ---

[Overview]
Executing 'abidiff' against to 'libc.so' from centos7.6's 'glibc' will cause
coredump, the output from 'bt' command of 'gdb' shows below:

/* gdb output begin */
(gdb) bt
#0  0x0000fffc4f1c66e0 in raise () from /lib64/libc.so.6
#1  0x0000fffc4f1c7a8c in abort () from /lib64/libc.so.6
#2  0x0000fffc4f1bfb8c in ?? () from /lib64/libc.so.6
#3  0x0000fffc4f1bfc0c in __assert_fail () from /lib64/libc.so.6
#4  0x0000fffc4faec370 in
abigail::dwarf::reader::lookup_fn_type_from_die_repr_per_tu
(die=0xfffffaba53c8, this=0x7cd2e30) at abg-dwarf-reader.cc:3506
#5  abigail::dwarf::build_function_type (rdr=..., die=die@entry=0xfffffaba53c8,
is_method=std::shared_ptr (empty) 0x0, where_offset=where_offset@entry=335444)
    at abg-dwarf-reader.cc:13781
#6  0x0000fffc4faec90c in abigail::dwarf::build_function_decl (rdr=...,
die=die@entry=0xfffffaba53c8, where_offset=where_offset@entry=335444,
fn=std::shared_ptr (empty) 0x0)
    at abg-dwarf-reader.cc:14927
...
#11 abigail::dwarf::reader::read_debug_info_into_corpus
(this=this@entry=0x7cd2e30) at abg-dwarf-reader.cc:2188
#12 0x0000fffc4fb04eb4 in abigail::dwarf::reader::read_corpus (this=0x7cd2e30,
status=@0xfffffaba5728: abigail::fe_iface::STATUS_OK) at
abg-dwarf-reader.cc:2078
#13 0x00000000004058c8 in main (argc=<optimized out>, argv=0xfffffaba5ba8) at
abidiff.cc:1242
/* gdb output end */

[Steps to Reproduce]
(1)confirm that we at the latest master branch
# git remote -v
origin  git://sourceware.org/git/libabigail.git (fetch)
origin  git://sourceware.org/git/libabigail.git (push)
# git branch
* master
# git log -5 --oneline
83bbc679 (HEAD -> master, origin/master, origin/HEAD) elf-reader: reclaim fd
and mem before break
e1aadfa5 Bug 29901 - abidiff hangs when comparing libgs.so.10 with itself
3c6a461b Update website documentation for 2.2
73d8782c configure: Bump version number to 2.3
7a7a00c3 ChangeLog: Update for 2.2 release
# ./configure
# make
(2)assure the newly compiled 'abidiff' is linked to the newly compiled
'libabigail.so'
# pwd
/root/tmp/libabigail-git
# ldd tools/.libs/abidiff
        ...
        libabigail.so.1 => /root/tmp/libabigail-git/src/.libs/libabigail.so.1
(0x0000fffc84820000)
        ...
(3)download 'libc.so' from centos7.6's 'glibc'
# mkdir glibc/ && cd glibc/
# wget
https://vault.centos.org/7.6.1810/os/x86_64/Packages/glibc-2.17-260.el7.x86_64.rpm
# wget
http://debuginfo.centos.org/7/x86_64/glibc-debuginfo-2.17-260.el7.x86_64.rpm
# mkdir with-debug/ without-debug/
# rpm2cpio glibc-2.17-260.el7.x86_64.rpm | cpio -idum -D without-debug/
# rpm2cpio glibc-debuginfo-2.17-260.el7.x86_64.rpm | cpio -idum -D with-debug/
# cd ../
(4)use newly compiled 'abidiff' to reproducing the problem that causes coredump
# ./tools/.libs/abidiff --d1 glibc/with-debug/usr/lib/debug/ --d2
glibc/with-debug/usr/lib/debug/ glibc/without-debug/lib64/libc-2.17.so
glibc/without-debug/lib64/libc-2.17.so

[Actual Results]
'abidiff' crashes with coredump:

/* crash output begin */
abidiff: abg-dwarf-reader.cc:3506: abigail::ir::function_type_sptr
abigail::dwarf::reader::lookup_fn_type_from_die_repr_per_tu(const Dwarf_Die*):
Assertion `__abg_cond__' failed.
Aborted (core dumped)
/* crash output end */

[Expected Results]
'abidiff' finishes without messages because the two libraries are same.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/29932] abidiff coredump at abg-dwarf-reader.cc:lookup_fn_type_from_die_repr_per_tu when read libc.so from glibc

[hexiaole1994 at 126 dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=29932

Xiaole He <hexiaole1994 at 126 dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|abidiff coredump at         |abidiff coredump at
                   |abg-ir.cc:hash_as_canonical |abg-dwarf-reader.cc:lookup_
                   |_type_or_constant when read |fn_type_from_die_repr_per_t
                   |libc.so from glibc          |u when read libc.so from
                   |                            |glibc

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/29932] abidiff coredump at abg-dwarf-reader.cc:lookup_fn_type_from_die_repr_per_tu when read libc.so from glibc

[dodji at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=29932

dodji at redhat dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
     Ever confirmed|0                           |1
   Last reconfirmed|                            |2022-12-24

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/29932] abidiff coredump at abg-dwarf-reader.cc:lookup_fn_type_from_die_repr_per_tu when read libc.so from glibc

[dodji at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=29932

dodji at redhat dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #1 from dodji at redhat dot com ---
This should be fixed by commit
https://sourceware.org/git/?p=libabigail.git;a=commit;h=de45f1e69b96a1f7511c94837e1793136b384407
in the master branch of the Git repository.

The fix should be available in the coming 2.3 version of libabigail.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/29932] abidiff coredump at abg-dwarf-reader.cc:lookup_fn_type_from_die_repr_per_tu when read libc.so from glibc

[hexiaole1994 at 126 dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=29932

--- Comment #2 from Xiaole He <hexiaole1994 at 126 dot com> ---
(In reply to dodji from comment #1)
> This should be fixed by commit
> https://sourceware.org/git/?p=libabigail.git;a=commit;
> h=de45f1e69b96a1f7511c94837e1793136b384407 in the master branch of the Git
> repository.
> 
> The fix should be available in the coming 2.3 version of libabigail.

Thank you agin, dodji, for using your precious time in resolving this problem.
I already verified that this problem has disappeared using the updated master
branch of git repository. How amazing man you are, good job!

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/29932] abidiff coredump at abg-dwarf-reader.cc:lookup_fn_type_from_die_repr_per_tu when read libc.so from glibc

[dodji at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=29932

--- Comment #3 from dodji at redhat dot com ---
(In reply to Xiaole He from comment #2)
> (In reply to dodji from comment #1)
> > This should be fixed by commit
> > https://sourceware.org/git/?p=libabigail.git;a=commit;
> > h=de45f1e69b96a1f7511c94837e1793136b384407 in the master branch of the Git
> > repository.
> > 
> > The fix should be available in the coming 2.3 version of libabigail.
> 
> Thank you agin, dodji, for using your precious time in resolving this
> problem. I already verified that this problem has disappeared using the
> updated master branch of git repository. How amazing man you are, good job!

You are too kind :-)

Thank *YOU* for taking the time to report these problems.  That's the first
step that allows us to have a better system overall.  So really thank you for
reporting these issues.  And sorry for the inconvenience.

-- 
You are receiving this mail because:
You are on the CC list for the bug.