From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sourceware-bugzilla@sourceware.org>
Received: by sourceware.org (Postfix, from userid 48)
	id 5584A385DC19; Fri,  7 Jul 2023 08:39:37 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5584A385DC19
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org;
	s=default; t=1688719177;
	bh=fpaHRVzVFRP73gRn/m03jn7KTNliAIYM7GeWSC8OqI0=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=HiiyK8eSyUMw8FOlIBMSIAU3dFBy0ZF5uWJ9ObJydy7/KCpDQ5VSFYiX/u8dYhZpU
	 XvBsyh7tCnSv5gX0xzeMETcuz1P7F/CDEa3D8628zxMK7LV01TC7osx4S8qI8aZ5Ul
	 TMraf7reftVhyBNT02VrMFCs1dEXmFlphMWz5zvU=
From: "dodji at seketeli dot org" <sourceware-bugzilla@sourceware.org>
To: libabigail@sourceware.org
Subject: [Bug default/30034] [libabigail] Handle library splitting
Date: Fri, 07 Jul 2023 08:39:05 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: libabigail
X-Bugzilla-Component: default
X-Bugzilla-Version: unspecified
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: enhancement
X-Bugzilla-Who: dodji at seketeli dot org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: dodji at redhat dot com
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-30034-9487-V9ZBqbj8oM@http.sourceware.org/bugzilla/>
In-Reply-To: <bug-30034-9487@http.sourceware.org/bugzilla/>
References: <bug-30034-9487@http.sourceware.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <libabigail.sourceware.org>

https://sourceware.org/bugzilla/show_bug.cgi?id=3D30034

--- Comment #24 from dodji at seketeli dot org ---
"david.marchand at redhat dot com via Libabigail"
<libabigail@sourceware.org> a =C3=A9crit:

[...]


> --- Comment #23 from David Marchand <david.marchand at redhat dot com> ---
> For the record, before I go off for some weeks.

[...]


> - You may want to fix typos (invalid -to suffix in the options) in the RE=
ADME
> file:

Fixed.

> - The mandatory aspect of the --add-binaries-toX options is disturbing, b=
ut it
> seems to work if I pass an empty list --add-binaries-to1=3D

Fixed.  The --add-binaries1=3D is no longer necessary if you have
specified a --add-binaries2=3D, for instance.

> - Requiring a '=3D' for those --add-binariesX options is surprising as ot=
her
> options won't accept a =3D.

Fixed.  The '=3D' is no longer necessary.

> - Now performance / runtime wise, before the DPDK split:
> * before the DPDK split, with 2.2 libabigail package from fc37:
> real    0m2,233s
> user    0m20,185s
> sys     0m2,354s
> * before the DPDK split, with libabigail binaries generated against this =
branch
> and no change in abidiff runtime:
> real    0m2,414s
> user    0m21,802s
> sys     0m3,502s
>
> And with the DPDK split:
> * using --follow-dependencies + --add-binaries-dirX:
> real    0m20,935s
> user    3m4,397s
> sys     1m45,828s
> * using --add-binaries1=3D --add-binaries2=3Dlibrte_log.so + --add-binari=
es-dirX:
> real    0m2,703s
> user    0m24,006s
> sys     0m4,458s
>
> Which seems acceptable to me :-).

Good to hear.

I have updated the branch with the fixes.

Thank you for testing and providing this timely and valuable feedback.

--=20
You are receiving this mail because:
You are on the CC list for the bug.=