From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sourceware-bugzilla@sourceware.org>
Received: by sourceware.org (Postfix, from userid 48)
	id DE73D385697B; Thu,  6 Jul 2023 13:38:48 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DE73D385697B
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org;
	s=default; t=1688650728;
	bh=b/I3EVeEj2brHAA07IGwqX+l4eEjXyxpnaHDCouyeDw=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=TY1EoIvxPZnTD/lrihoJCArdGsoz8kw3/n4vxKiIo3qqwwJWl/OPJbiwjELHa+vj9
	 HfSMPLv23ryCKKi4gdizOGOD96HkVRoG/vPu1Xvplyc6vYmv7/9CRq2TQ3+/3HbHzw
	 xZa3snIxc4LjPWBMNsUn0OHhU4YrniHq3KAaQ1Og=
From: "david.marchand at redhat dot com" <sourceware-bugzilla@sourceware.org>
To: libabigail@sourceware.org
Subject: [Bug default/30034] [libabigail] Handle library splitting
Date: Thu, 06 Jul 2023 13:38:47 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: libabigail
X-Bugzilla-Component: default
X-Bugzilla-Version: unspecified
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: enhancement
X-Bugzilla-Who: david.marchand at redhat dot com
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: dodji at redhat dot com
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-30034-9487-zb5c9weuLa@http.sourceware.org/bugzilla/>
In-Reply-To: <bug-30034-9487@http.sourceware.org/bugzilla/>
References: <bug-30034-9487@http.sourceware.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <libabigail.sourceware.org>

https://sourceware.org/bugzilla/show_bug.cgi?id=3D30034

--- Comment #23 from David Marchand <david.marchand at redhat dot com> ---
For the record, before I go off for some weeks.

I tried:
$ git describe
libabigail-2.3-18-g91682eaf
$ git ll | head -3
91682eaf - (HEAD -> PR30034, origin/users/dodji/try-PR30034,
origin/users/dodji/PR30034) abidiff: Add --{follow,list}-dependencies &
add-binaries{1,2} support (47 minutes ago) <Dodji Seketeli>
daba3581 - abidw: Add --{follow,list}-dependencies & --add-binaries=3D supp=
ort
(47 minutes ago) <Dodji Seketeli>
a72b5046 - corpus,tools-utils: Support loading a corpus, its deps & other
binaries (47 minutes ago) <Dodji Seketeli>


- You may want to fix typos (invalid -to suffix in the options) in the READ=
ME
file:
README-ABIDIFF-BINARIES-SET-SUPPORT.md:    $ abidiff
--add-binaries-to1=3Dfile2-v1           \
README-ABIDIFF-BINARIES-SET-SUPPORT.md:=20=20=20=20=20=20=20=20=20=20=20=20=
=20
--add-binaries-to2=3Dfile2-v2,file2-v1  \

- The mandatory aspect of the --add-binaries-toX options is disturbing, but=
 it
seems to work if I pass an empty list --add-binaries-to1=3D

- Requiring a '=3D' for those --add-binariesX options is surprising as other
options won't accept a =3D.

- Now performance / runtime wise, before the DPDK split:
* before the DPDK split, with 2.2 libabigail package from fc37:
real    0m2,233s
user    0m20,185s
sys     0m2,354s
* before the DPDK split, with libabigail binaries generated against this br=
anch
and no change in abidiff runtime:
real    0m2,414s
user    0m21,802s
sys     0m3,502s

And with the DPDK split:
* using --follow-dependencies + --add-binaries-dirX:
real    0m20,935s
user    3m4,397s
sys     1m45,828s
* using --add-binaries1=3D --add-binaries2=3Dlibrte_log.so + --add-binaries=
-dirX:
real    0m2,703s
user    0m24,006s
sys     0m4,458s

Which seems acceptable to me :-).

--=20
You are receiving this mail because:
You are on the CC list for the bug.=