From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sourceware-bugzilla@sourceware.org>
Received: by sourceware.org (Postfix, from userid 48)
	id E10623858D32; Sun, 26 Mar 2023 03:18:20 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E10623858D32
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org;
	s=default; t=1679800700;
	bh=/V02Y5esJKAdaTEor6q35QYolgSPfeQ2XUqTMPiIUpY=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=wWgFG9nT0mEWhzIvqlagGbRuaOR6FrTXkqjjMIxKezjSCazoz6h5uyNeJWOlplfkr
	 nMAQwJxZKECqC5+pGSDQsPHZxIfPq7+0k61SemmJaRtZrNgz3sYfX5dCNhc5FPz1hK
	 sIqEIgI7gg5AJNinQkrjMQjxIPwrRCTFQJLe7d4Y=
From: "fche at redhat dot com" <sourceware-bugzilla@sourceware.org>
To: libabigail@sourceware.org
Subject: [Bug default/30274] RFE have fedabipkgdiff prefer debuginfod when
 available
Date: Sun, 26 Mar 2023 03:18:19 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: libabigail
X-Bugzilla-Component: default
X-Bugzilla-Version: unspecified
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: fche at redhat dot com
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: dodji at redhat dot com
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-30274-9487-BBJl3H1xkj@http.sourceware.org/bugzilla/>
In-Reply-To: <bug-30274-9487@http.sourceware.org/bugzilla/>
References: <bug-30274-9487@http.sourceware.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <libabigail.sourceware.org>

https://sourceware.org/bugzilla/show_bug.cgi?id=3D30274

--- Comment #1 from Frank Ch. Eigler <fche at redhat dot com> ---
fedabipkgdiff does a busy loop on waitpid() on the abipkgdiff child process:

@log_call
def abipkgdiff(cmp_half1, cmp_half2):
    [...]
    proc =3D subprocess.Popen(' '.join(cmd), shell=3DTrue,
                            stdout=3Dsubprocess.PIPE, stderr=3Dsubprocess.P=
IPE,
                            universal_newlines=3DTrue)
    # So we could have done: stdout, stderr =3D proc.communicate()
    # But then the documentatin of proc.communicate says:
    #
    #    Note: The data read is buffered in memory, so do not use this
    #    method if the data size is large or unlimited. "
    #
    # In practice, we are seeing random cases where this
    # proc.communicate() function does *NOT* terminate and seems to be
    # in a deadlock state.  So we are avoiding it altogether.  We are
    # then busy looping, waiting for the spawn process to finish, and
    # then we get its output.
    #

    while True:
        if proc.poll() !=3D None:
            break


Not sure that interpretation of python docs is correct, but even then, a wee
bit of sleep wouldn't hurt.

--=20
You are receiving this mail because:
You are on the CC list for the bug.=