public inbox for libabigail@sourceware.org
 help / color / mirror / Atom feed
From: "woodard at redhat dot com" <sourceware-bugzilla@sourceware.org>
To: libabigail@sourceware.org
Subject: [Bug default/30363] Location of return type not tracked in ABI model.
Date: Tue, 18 Apr 2023 00:05:36 +0000	[thread overview]
Message-ID: <bug-30363-9487-4AqOtOriUa@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-30363-9487@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=30363

--- Comment #1 from Ben Woodard <woodard at redhat dot com> ---
I know one of the founding principles of libabigail is that it assumes the
compiler implements the calling convention correctly. I do not think that this
is entirely sufficient. I think that there are several cases where we should
also verify parameter and return type locations.

1) Compiler bugs such as this one
2) Compilation options, for example if the same library with the same defined
types were compiled without SSE support then the compiler may choose a
different version of the calling convention which passed the vector array type
by pointer reference rather than as a value in a vector register. This one is
really subtle and may be the source of several problems that we have here in
HPC.
3) Inter compiler variation, there are subtle cases where differences in the
interpretation of the calling convention could lead to differences in the
allocation of registers and stack. In theory, this should not happen but it
actually does and this has been a problem that has led to the entire HPC
community creating vertical software stacks with every compiler.

Therefore, I believe that we need to include the location of the parameters and
the return value in our ABI model to catch these problems.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

      reply	other threads:[~2023-04-18  0:05 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-17 14:19 [Bug default/30363] New: " woodard at redhat dot com
2023-04-18  0:05 ` woodard at redhat dot com [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-30363-9487-4AqOtOriUa@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=libabigail@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).