* [Bug default/30931] Support check-uapi.sh
2023-10-02 13:53 [Bug default/30931] New: Support check-uapi.sh dodji at redhat dot com
@ 2023-10-02 13:57 ` dodji at redhat dot com
2023-10-05 13:31 ` dodji at redhat dot com
` (6 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: dodji at redhat dot com @ 2023-10-02 13:57 UTC (permalink / raw)
To: libabigail
https://sourceware.org/bugzilla/show_bug.cgi?id=30931
--- Comment #1 from dodji at redhat dot com ---
Patches related to the "better anonymous enum change support" are being
accumulated in the branch
https://sourceware.org/git/?p=libabigail.git;a=shortlog;h=refs/heads/users/dodji/better-anon-enums,
before being merged into the branch
https://sourceware.org/git/?p=libabigail.git;a=shortlog;h=refs/heads/users/dodji/check-uapi-support.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug default/30931] Support check-uapi.sh
2023-10-02 13:53 [Bug default/30931] New: Support check-uapi.sh dodji at redhat dot com
2023-10-02 13:57 ` [Bug default/30931] " dodji at redhat dot com
@ 2023-10-05 13:31 ` dodji at redhat dot com
2023-10-12 15:48 ` dodji at redhat dot com
` (5 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: dodji at redhat dot com @ 2023-10-05 13:31 UTC (permalink / raw)
To: libabigail
https://sourceware.org/bugzilla/show_bug.cgi?id=30931
dodji at redhat dot com changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
--- Comment #2 from dodji at redhat dot com ---
Patches related to the suppressing data member insertion right before flexible
array data members are being accumulated in the "fam-suppr" branch at
https://sourceware.org/git/?p=libabigail.git;a=shortlog;h=refs/heads/users/dodji/fam-suppr.
The description of what we want is discussed in the message
https://inbox.sourceware.org/libabigail/153dc338-ff1f-4273-1663-e934124e4bcc@quicinc.com/
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug default/30931] Support check-uapi.sh
2023-10-02 13:53 [Bug default/30931] New: Support check-uapi.sh dodji at redhat dot com
2023-10-02 13:57 ` [Bug default/30931] " dodji at redhat dot com
2023-10-05 13:31 ` dodji at redhat dot com
@ 2023-10-12 15:48 ` dodji at redhat dot com
2023-10-13 15:27 ` dodji at redhat dot com
` (4 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: dodji at redhat dot com @ 2023-10-12 15:48 UTC (permalink / raw)
To: libabigail
https://sourceware.org/bugzilla/show_bug.cgi?id=30931
dodji at redhat dot com changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |quic_johmoo at quicinc dot com
--- Comment #3 from dodji at redhat dot com ---
The branches "better-anon-enum" and "fam-suppr" have now been merged into the
branch "check-uapi-support". This is as John Moon told me off-list that he
tested the two former branches.
The check-uapi-support branch now has all the patches we have been working on
to support the check-uapi.sh program so far.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug default/30931] Support check-uapi.sh
2023-10-02 13:53 [Bug default/30931] New: Support check-uapi.sh dodji at redhat dot com
` (2 preceding siblings ...)
2023-10-12 15:48 ` dodji at redhat dot com
@ 2023-10-13 15:27 ` dodji at redhat dot com
2023-10-13 17:13 ` quic_johmoo at quicinc dot com
` (3 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: dodji at redhat dot com @ 2023-10-13 15:27 UTC (permalink / raw)
To: libabigail
https://sourceware.org/bugzilla/show_bug.cgi?id=30931
--- Comment #4 from dodji at redhat dot com ---
So, on the branch "users/dodji/check-uapi-support", the issue we were having
with anonymous enums is present also for anonymous unions & structs.
In short, here is what we have:
For example:
union {
int a;
int b;
};
------
union {
int a;
int b;
int c;
};
Yields:
1 removed type unreachable from any public interface:
[D] 'union {int a; int b;}' at test_1.c:1:1
1 added type unreachable from any public interface:
[A] 'union {int a; int b; int c;}' at test_2.c:1:1
This has been reported off-list by John Moon.
To handle this issue I created the branch
https://sourceware.org/git/?p=libabigail.git;a=shortlog;h=refs/heads/users/dodji/better-anon-class
with the patch
https://sourceware.org/git/?p=libabigail.git;a=commit;h=2776e2590e269f2b304b49f8626d52b77ca5ae54.
When John agrees, I'll merge that patch into the
"users/dodji/check-uapi-support" branch.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug default/30931] Support check-uapi.sh
2023-10-02 13:53 [Bug default/30931] New: Support check-uapi.sh dodji at redhat dot com
` (3 preceding siblings ...)
2023-10-13 15:27 ` dodji at redhat dot com
@ 2023-10-13 17:13 ` quic_johmoo at quicinc dot com
2023-10-13 19:32 ` dodji at redhat dot com
` (2 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: quic_johmoo at quicinc dot com @ 2023-10-13 17:13 UTC (permalink / raw)
To: libabigail
https://sourceware.org/bugzilla/show_bug.cgi?id=30931
--- Comment #5 from John Moon <quic_johmoo at quicinc dot com> ---
Agreed - the patch fixes the issue. Thanks for the quick turnaround!
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug default/30931] Support check-uapi.sh
2023-10-02 13:53 [Bug default/30931] New: Support check-uapi.sh dodji at redhat dot com
` (4 preceding siblings ...)
2023-10-13 17:13 ` quic_johmoo at quicinc dot com
@ 2023-10-13 19:32 ` dodji at redhat dot com
2023-10-17 8:59 ` dodji at redhat dot com
2023-10-20 23:08 ` dodji at redhat dot com
7 siblings, 0 replies; 9+ messages in thread
From: dodji at redhat dot com @ 2023-10-13 19:32 UTC (permalink / raw)
To: libabigail
https://sourceware.org/bugzilla/show_bug.cgi?id=30931
--- Comment #6 from dodji at redhat dot com ---
> Agreed - the patch fixes the issue.
OK, so I have merged the patch into the branch
https://sourceware.org/git/?p=libabigail.git;a=shortlog;h=refs/heads/users/dodji/check-uapi-support.
> Thanks for the quick turnaround!
My pleasure!
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug default/30931] Support check-uapi.sh
2023-10-02 13:53 [Bug default/30931] New: Support check-uapi.sh dodji at redhat dot com
` (5 preceding siblings ...)
2023-10-13 19:32 ` dodji at redhat dot com
@ 2023-10-17 8:59 ` dodji at redhat dot com
2023-10-20 23:08 ` dodji at redhat dot com
7 siblings, 0 replies; 9+ messages in thread
From: dodji at redhat dot com @ 2023-10-17 8:59 UTC (permalink / raw)
To: libabigail
https://sourceware.org/bugzilla/show_bug.cgi?id=30931
--- Comment #7 from dodji at redhat dot com ---
I have rebased the WIP branch
https://sourceware.org/git/?p=libabigail.git;a=shortlog;h=refs/heads/users/dodji/check-uapi-support
on top of the commit below which is the current tip of the master branch as I
am writing this:
a1256078 Bug 30971 - Wrong interpretation of "has_data_member_inserted_at"
Is there a task left to support the UAPI compatibility checker? I am reviewing
the patches in the WIP branch to get them ready for merging into the master
branch at this point. If there is a task left for which I can help, please let
me know.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug default/30931] Support check-uapi.sh
2023-10-02 13:53 [Bug default/30931] New: Support check-uapi.sh dodji at redhat dot com
` (6 preceding siblings ...)
2023-10-17 8:59 ` dodji at redhat dot com
@ 2023-10-20 23:08 ` dodji at redhat dot com
7 siblings, 0 replies; 9+ messages in thread
From: dodji at redhat dot com @ 2023-10-20 23:08 UTC (permalink / raw)
To: libabigail
https://sourceware.org/bugzilla/show_bug.cgi?id=30931
dodji at redhat dot com changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution|--- |FIXED
--- Comment #8 from dodji at redhat dot com ---
The patches of the branch "check-uapi-support" have been merged in the master
branch of the git repository.
The support for the check-uapi.sh tool should thus be available in libabigail
2.4.
Thanks!
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 9+ messages in thread