From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sourceware-bugzilla@sourceware.org>
Received: by sourceware.org (Postfix, from userid 48)
	id 22AF63858D33; Wed,  8 Nov 2023 12:03:44 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 22AF63858D33
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org;
	s=default; t=1699445024;
	bh=4cem5iE9IB2XjRNpvFhQAQ4A5Z6V2Nnjlw5yeobGpmE=;
	h=From:To:Subject:Date:From;
	b=F4rD+oirsDN3195GS+ZiwQwaXSbq3FX1IYxf2hKR1FSlRshx2D8RhZ4IT5qd/SzYx
	 asK1UTuvhxoxTCUWxtgi7TaQVIoH10rAQ3/OczFYZr3DREDY0fe6N2zdaWET0idVHe
	 zedeoEsX9XQBIbtddvKgSvjNfikrc4ukGOhDP+Ik=
From: "paolo.pisati at canonical dot com"
 <sourceware-bugzilla@sourceware.org>
To: libabigail@sourceware.org
Subject: [Bug default/31045] New: libabigail-2.4: Assertion `__abg_cond__'
 failed. Aborted (core dumped)
Date: Wed, 08 Nov 2023 12:03:43 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: libabigail
X-Bugzilla-Component: default
X-Bugzilla-Version: unspecified
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: paolo.pisati at canonical dot com
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: dodji at redhat dot com
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: bug_id short_desc product version bug_status
 bug_severity priority component assigned_to reporter cc target_milestone
 attachments.created
Message-ID: <bug-31045-9487@http.sourceware.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <libabigail.sourceware.org>

https://sourceware.org/bugzilla/show_bug.cgi?id=3D31045

            Bug ID: 31045
           Summary: libabigail-2.4: Assertion `__abg_cond__' failed.
                    Aborted (core dumped)
           Product: libabigail
           Version: unspecified
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: default
          Assignee: dodji at redhat dot com
          Reporter: paolo.pisati at canonical dot com
                CC: libabigail at sourceware dot org
  Target Milestone: ---

Created attachment 15214
  --> https://sourceware.org/bugzilla/attachment.cgi?id=3D15214&action=3Ded=
it
zfs files that trigger the assert()

While building the zfs-dkms package, in the checkabi target, abidiff core
dumps:

https://launchpadlibrarian.net/696568269/buildlog_ubuntu-noble-amd64.zfs-li=
nux_2.2.0-0ubuntu2_BUILDING.txt.gz

abigail-2.3 was fine, and it started crashing after we moved to abigail-2.4.
I was able to reproduce the issue locally with abigail src from git:

$ abidiff --no-unreferenced-symbols --headers-dir1 include --suppressions
./lib/libnvpair/libnvpair.suppr ./lib/libnvpair/libnvpair.abi
.libs/libnvpair.so
abidiff: ../../src/abg-ir.cc:8004: virtual abigail::ir::decl_base_sptr
abigail::ir::scope_decl::add_member_decl(const abigail::ir::decl_base_sptr&=
):
Assertion `__abg_cond__' failed.
Aborted (core dumped)

and i bisected it down to this commit:

commit d00a2cc2da9b33be5a6e5376cbee4591c042d3a3 (break5)
Author: Dodji Seketeli <dodji@redhat.com>
Date:   Thu May 25 14:15:56 2023 +0200

    Bug 30466 - harfbuzz fails self-check on f38

Does it ring any bell?
I'm not familiar with abigail internals, but i'll be happy to test any patch
you throw at me.

I'm attaching a tarball with the offending files.

--=20
You are receiving this mail because:
You are on the CC list for the bug.=