From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id 4BC843858291; Tue, 2 Apr 2024 13:16:33 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4BC843858291 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1712063793; bh=AcI98k5z0uwXEEs5zaE/bISKKaMwLexo2peKS6nX/EQ=; h=From:To:Subject:Date:In-Reply-To:References:From; b=TT0SYx9hO0oCB4ABM7DOR32QGZEJyj1tLXbxiF0wzmf+YVwgkltPWx9pzLR+Z6Qiq rZIdA9hPdBIkkbd5p/bt26r0Nys0UYRELucx5h7at4Uolq9kKa+ONFO0O++ua3bxuI aS2nJR29wM+GJQzxo/R7cSFVO5f5OzPfTtLyEMgw= From: "quic_jiafan at quicinc dot com" To: libabigail@sourceware.org Subject: [Bug default/31513] abidiff wrongly considers data members moved to base class as harmful Date: Tue, 02 Apr 2024 13:16:32 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: libabigail X-Bugzilla-Component: default X-Bugzilla-Version: unspecified X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: quic_jiafan at quicinc dot com X-Bugzilla-Status: RESOLVED X-Bugzilla-Resolution: FIXED X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: dodji at seketeli dot org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 List-Id: https://sourceware.org/bugzilla/show_bug.cgi?id=3D31513 Jianfeng Fan changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |quic_jiafan at quicinc dot= com --- Comment #14 from Jianfeng Fan --- Hi, There may be an issue in the commit https://sourceware.org/git/?p=3Dlibabigail.git;a=3Dcommit;h=3D338394f545499= 0c715b52bb4bc2ed47b39d6528b in abg-comp-filter.cc https://sourceware.org/git/?p=3Dlibabigail.git;a=3Dblobdiff;f=3Dsrc/abg-com= p-filter.cc;h=3Dcaea9d0c5308264b40f9b07f5d1bdfebef5caae4;hp=3D63716775ee8eb= e482a7b2f0c504e42372979d77e;hb=3D338394f5454990c715b52bb4bc2ed47b39d6528b;h= pb=3Da917072c12449cfea03e79a6e82e286e0f54f57b Added inline comments static bool has_subtype_changes(const string_decl_base_sptr_map& f_data_members, const string_decl_base_sptr_map& s_data_members, diff_context_sptr ctxt) { // Now compare the offsets of the data members collected. var_decl_sptr s_member; for (auto entry : f_data_members) { var_decl_sptr f_member =3D is_var_decl(entry.second); ABG_ASSERT(f_member); auto i =3D s_data_members.find(entry.first); if (i =3D=3D s_data_members.end()) { unsigned offset =3D get_data_member_offset(f_member); s_member =3D find_data_member_at_offset(s_data_members, offset); if (!s_member) // A data member was suppressed; that's bad; let's consider // that as a sub-type change. return true; } if (!s_member) <<<<<<<<< we never reset s_member, so it will only be assigned once, each f_member compare to the first s_member. s_member =3D is_var_decl(i->second); ABG_ASSERT(s_member); diff_sptr d =3Dcompute_diff(f_member->get_type(), s_member->get_type(= ), ctxt); <<<<<<<<< we can add s_member.reset(); here, s_member can be updated = next time. if (d->has_changes()) return true; } return false; } With this change, the result for test case report1.txt can be changed to Functions changes summary: 0 Removed, 0 Changed (1 filtered out), 0 Added function Variables changes summary: 0 Removed, 0 Changed, 0 Added variable --=20 You are receiving this mail because: You are on the CC list for the bug.=