From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id D013A3858D34; Fri, 29 Mar 2024 17:40:34 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D013A3858D34 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1711734034; bh=FDFA3nWjVwiifgdcbOD6kGY4WJqTTSuXUGyuMZ7ZvvM=; h=From:To:Subject:Date:In-Reply-To:References:From; b=xMg12L3rEcUe+yW9Rdmf6EFpwoF85MB/WMDii7qTp92nZyrMO6XABHb6GB+2lkUCM vm4kjHv18aWHHSiZz8XUqLYfLKzwFbXQb6qjHhXN4Ec/0kbovuH1udG8e9n8XxPpgh H+xJH/dsFjBPfyDdQTO8162LQCGkLtsq+xXGIS6Q= From: "dodji at seketeli dot org" To: libabigail@sourceware.org Subject: [Bug default/31513] abidiff wrongly considers data members moved to base class as harmful Date: Fri, 29 Mar 2024 17:40:33 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: libabigail X-Bugzilla-Component: default X-Bugzilla-Version: unspecified X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: dodji at seketeli dot org X-Bugzilla-Status: ASSIGNED X-Bugzilla-Resolution: X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: dodji at seketeli dot org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 List-Id: https://sourceware.org/bugzilla/show_bug.cgi?id=3D31513 --- Comment #11 from Dodji Seketeli --- Hello, I have posted a candidate patch for this issue in commit https://sourceware.org/git/?p=3Dlibabigail.git;a=3Dcommit;h=3D338394f545499= 0c715b52bb4bc2ed47b39d6528b. You can get it from the Git repository of the project in the branch "users/dodji/fixes" that can be browsed at https://sourceware.org/git/?p=3Dlibabigail.git;a=3Dshortlog;h=3Drefs/heads/= users/dodji/fixes. You can check it out with the command: git clone -b users/dodji/fixes git://sourceware.org/git/libabigail.git. You can build the source code by following the instructions at https://sourceware.org/git/?p=3Dlibabigail.git;a=3Dblob;f=3DCOMPILING. Please note that running abidiff on the two binaries that you provided shows that several functions (instantiations of libstdc++ function templates) were removed from the first binary. That is why abidiff sets the bit ABIDIFF_ABI_INCOMPATIBLE_CHANGE in the exit value. To suppress the noise coming from these libstdc++ function template instantiations (which could be avoided by using the symbol visibility optio= ns of g++, by the way), I provided a suppression file in the non-regression te= sts accompanying the patch at https://sourceware.org/git/?p=3Dlibabigail.git;a=3Dblob;f=3Dtests/data/test= -abidiff-exit/PR31513/reported/libstdcpp.suppr;h=3D6c3761006a7c304c8a98dfd2= a74097ef9e3282e2;hb=3D338394f5454990c715b52bb4bc2ed47b39d6528b. You might want to test this branch on your system and tell me if that fixes= the issue for you. I hope this helps. --=20 You are receiving this mail because: You are on the CC list for the bug.=