public inbox for libabigail@sourceware.org
 help / color / mirror / Atom feed
From: "dodji at redhat dot com" <sourceware-bugzilla@sourceware.org>
To: libabigail@sourceware.org
Subject: [Bug default/31672] abidb: make libarchive a soft dependency
Date: Fri, 26 Apr 2024 14:18:38 +0000	[thread overview]
Message-ID: <bug-31672-9487-Ldf5SOvkrb@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-31672-9487@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=31672

--- Comment #4 from dodji at redhat dot com ---
Hey Frank,

Dodji Seketeli <dodji@seketeli.org> a écrit:

> Now, the updated patch below actually passes the test on all the tested
> platforms.  OK to apply to the master branch?

So, after your ACK on IRC, I went ahead and applied the patch.

> From f41d17301f75fab61366bd7b568418d2a9c30567 Mon Sep 17 00:00:00 2001
> From: "Frank Ch. Eigler" <fche@redhat.com>
> Date: Fri, 26 Apr 2024 10:30:42 +0200
> Subject: [PATCH] configure,abidb: Make the libarchive python module optional for abidb
>
> Some distributions don't have the libarchive python module packaged.
>
> This patch makes that module optional and enables abidb to function
> without it, as it's only necessary for the support of the '--archive'
> command line option of the abidb program.
>
> 	* configure.ac: Detect the libarchive python module as an optional
> 	dependency for the abidb program.  So far, only the git python
> 	module remains a hard dependency.
> 	* tools/abidb (main): Do not support the '--archive' command line
> 	option if the libarchive python module is not present.
>
> Signed-off-by: Dodji Seketeli <dodji@redhat.com>
> ---
>  configure.ac | 15 +++++++++++++--
>  tools/abidb  | 31 +++++++++++++++++++------------
>  2 files changed, 32 insertions(+), 14 deletions(-)

[...]

Thanks!

Cheers,

-- 
You are receiving this mail because:
You are on the CC list for the bug.

  parent reply	other threads:[~2024-04-26 14:18 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-23 13:41 [Bug default/31672] New: " fche at redhat dot com
2024-04-23 14:02 ` [Bug default/31672] " fche at redhat dot com
2024-04-26  8:44   ` [RFC] [PATCH] Make libarchive python module optional. Was " Dodji Seketeli
2024-04-26 13:59     ` Dodji Seketeli
2024-04-26 14:18       ` Dodji Seketeli
2024-04-26  8:44 ` dodji at seketeli dot org
2024-04-26 13:59 ` dodji at seketeli dot org
2024-04-26 14:18 ` dodji at redhat dot com [this message]
2024-04-26 14:19 ` dodji at seketeli dot org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-31672-9487-Ldf5SOvkrb@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=libabigail@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).