[Bug default/31836] New: Segmentation fault on tab completion

[Bug default/31836] New: Segmentation fault on tab completion

[mohd.akram at outlook dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=31836

            Bug ID: 31836
           Summary: Segmentation fault on tab completion
           Product: libabigail
           Version: unspecified
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: default
          Assignee: unassigned at sourceware dot org
          Reporter: mohd.akram at outlook dot com
                CC: libabigail at sourceware dot org
  Target Milestone: ---

To reproduce (on Poke 4.1):

```
(poke) load id3v2
(poke) .file music.mp3
(poke) var tag = ID3V2_Tag @ 0#B
(poke) tag.frames[0].<tab>Segmentation fault: 11
```

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/31836] Segmentation fault on tab completion

[mohd.akram at outlook dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=31836

Mohamed Akram <mohd.akram at outlook dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Product|libabigail                  |poke
                 CC|                            |poke-devel at gnu dot org
          Component|default                     |default

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/31836] Segmentation fault on tab completion

[ssbssa at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=31836

Hannes Domani <ssbssa at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
                 CC|                            |ssbssa at sourceware dot org
     Ever confirmed|0                           |1
   Last reconfirmed|                            |2024-06-02

--- Comment #1 from Hannes Domani <ssbssa at sourceware dot org> ---
It crashes in pkl_struct_type_traverse:

Thread 1 received signal SIGSEGV, Segmentation fault.
[Switching to Thread 8700.0x15b8]
pkl_struct_type_traverse (type=0x4caa6a0, path=path@entry=0x528ed20
"tag.frames[
0].") at ../../../poke.git/libpoke/pkl-ast.c:775
775                   if (STREQ (field, sub))

It's happening because the field name (ename) is accessed:

              ename = PKL_AST_STRUCT_TYPE_FIELD_NAME (t);
              field = PKL_AST_IDENTIFIER_POINTER (ename);

But there is no field name for the padding of ID3V2_TAG:

    /* Padding.  */
    uint<8>[hdr.get_size - (frames'offset + (frames'size))/#B];

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/31836] Segmentation fault on tab completion

[mnabipoor at gnu dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=31836

Mohammad-Reza Nabipoor <mnabipoor at gnu dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mnabipoor at gnu dot org
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from Mohammad-Reza Nabipoor <mnabipoor at gnu dot org> ---
Hi.

Thanks for the bug report and analysis.

The crash is fixed in commit `295fdd165d363a0cc09c244bfb6abcb01984ab01` in
master branch and in commit `04a275d0a0eb12736b6a41f7b35fc5593f876d4d` in
maint/poke-4 branch.

Thanks!

-- 
You are receiving this mail because:
You are on the CC list for the bug.