public inbox for libabigail@sourceware.org
 help / color / mirror / Atom feed
* [Bug default/31879] New: `has_data_member_inserted_at = end` not working
@ 2024-06-11 12:28 cnookala at roku dot com
  2024-06-11 12:30 ` [Bug default/31879] " cnookala at roku dot com
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: cnookala at roku dot com @ 2024-06-11 12:28 UTC (permalink / raw)
  To: libabigail

https://sourceware.org/bugzilla/show_bug.cgi?id=31879

            Bug ID: 31879
           Summary: `has_data_member_inserted_at = end` not working
           Product: libabigail
           Version: unspecified
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: default
          Assignee: unassigned at sourceware dot org
          Reporter: cnookala at roku dot com
                CC: libabigail at sourceware dot org
  Target Milestone: ---

I have two files, a.c and b.c:

```
// a.c
struct S
{
  int member1;
};

int
foo(struct S* s)
{
  return s->member1;
}

// b.c
struct S
{
  int member1;
  float member2;
};

int
foo(struct S* s)
{
  return s->member1;
}

```

In this case, libabigail reports an incompatibility (which it should). However,
since it is harmless, I would like to suppress it with suppressions.ini:

```
[suppress_type]
  name = S
  has_data_member_inserted_at = end
```

However, when I run `abidiff --suppr suppressions.ini a.xml b.xml`, it still
reports the error. I used `gcc -g -Wall -shared -o <file>.so <file>` to compile
and `abidw <file>.so > <file>.xml` to generate the XML files.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Bug default/31879] `has_data_member_inserted_at = end` not working
  2024-06-11 12:28 [Bug default/31879] New: `has_data_member_inserted_at = end` not working cnookala at roku dot com
@ 2024-06-11 12:30 ` cnookala at roku dot com
  2024-06-11 14:23 ` cnookala at roku dot com
  2024-06-11 14:23 ` cnookala at roku dot com
  2 siblings, 0 replies; 4+ messages in thread
From: cnookala at roku dot com @ 2024-06-11 12:30 UTC (permalink / raw)
  To: libabigail

https://sourceware.org/bugzilla/show_bug.cgi?id=31879

--- Comment #1 from Chaitu Nookala <cnookala at roku dot com> ---
FYI this has been tested on both master and version 2.5.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Bug default/31879] `has_data_member_inserted_at = end` not working
  2024-06-11 12:28 [Bug default/31879] New: `has_data_member_inserted_at = end` not working cnookala at roku dot com
  2024-06-11 12:30 ` [Bug default/31879] " cnookala at roku dot com
@ 2024-06-11 14:23 ` cnookala at roku dot com
  2024-06-11 14:23 ` cnookala at roku dot com
  2 siblings, 0 replies; 4+ messages in thread
From: cnookala at roku dot com @ 2024-06-11 14:23 UTC (permalink / raw)
  To: libabigail

https://sourceware.org/bugzilla/show_bug.cgi?id=31879

--- Comment #2 from Chaitu Nookala <cnookala at roku dot com> ---
It looks like I missed "Please note that if the size of the type changed, then
the type change will NOT be suppressed by the evaluation of this property,
unless the has_size_change property is present and set to yes" in the
documentation.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Bug default/31879] `has_data_member_inserted_at = end` not working
  2024-06-11 12:28 [Bug default/31879] New: `has_data_member_inserted_at = end` not working cnookala at roku dot com
  2024-06-11 12:30 ` [Bug default/31879] " cnookala at roku dot com
  2024-06-11 14:23 ` cnookala at roku dot com
@ 2024-06-11 14:23 ` cnookala at roku dot com
  2 siblings, 0 replies; 4+ messages in thread
From: cnookala at roku dot com @ 2024-06-11 14:23 UTC (permalink / raw)
  To: libabigail

https://sourceware.org/bugzilla/show_bug.cgi?id=31879

Chaitu Nookala <cnookala at roku dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |NOTABUG

--- Comment #3 from Chaitu Nookala <cnookala at roku dot com> ---
Marking as resolved

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2024-06-11 14:23 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-06-11 12:28 [Bug default/31879] New: `has_data_member_inserted_at = end` not working cnookala at roku dot com
2024-06-11 12:30 ` [Bug default/31879] " cnookala at roku dot com
2024-06-11 14:23 ` cnookala at roku dot com
2024-06-11 14:23 ` cnookala at roku dot com

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).