From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by sourceware.org (Postfix) with ESMTPS id 47F583858D38 for ; Wed, 10 Jan 2024 17:24:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 47F583858D38 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=quicinc.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 47F583858D38 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704907491; cv=none; b=oEXL/OUAxTgmeOrDrIOZO8aSuoTYLkYp8V+RU138Eh9Ua7kouf6njvKj19N22nrVUdMGBWPq0++/KCE6ur+uXy1C7DOUdV6q0JwbeKANcZBvHu7vE0bd2n3gNfsOGMG/qL7gzxiRzV4om9AYY/PQfGYv+QUYezn16sMmgJdL9Do= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704907491; c=relaxed/simple; bh=8O5ZGy01chHe2bisrR5kq50jxGuV8GInAJ2Z8gbLM94=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=RN4s1fzM8ng2xc6jPxFUKRejrsdNYjd/yhPppzis0J/YzVDXtcuv9kBxU9etUlT8IpxCXorixSipE6oqOFBHUt2kNUc/8VDdzU42/TCY27drmHv1272Nkg1pV844hNe+a9AS4x0pfWwGjAnuz3WOKklaY9jZ3m5KEx4ishSflXc= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 40AGPCg0015335; Wed, 10 Jan 2024 17:24:13 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= message-id:date:mime-version:subject:to:cc:references:from :in-reply-to:content-type:content-transfer-encoding; s= qcppdkim1; bh=zM7XUSd8Y2tio1BavZrFWOH4tGIFE7jU5+Azvnh3t/g=; b=RJ fDNQBAZ+EH6KMFGV/NwEgVTtL5yTtHgCB6X9ui1E+EsrPdLzOSeOpah55SHbs6YU rXFmf3Qh6vZp5EeQ/pgS2mnc5CQp1MgRHfQ1oGUX5lum6UtOBSiLFzBjV8kJGXpE ZNWpETJLE0UAglWRldBHMIEx7v3HzGZ1a05sphGLtx0vO68zgwVKXhj+a1DKknNB zTrHMABIe4RnD7N0QNA15/WZM5mDY29YOLL+dQrV6ZebznwqLUFd0ePjrlZbw+B/ pARVYCN6MaJG8L3qzlWKn0pXiElXkRDKWQZIZLSLH1zJ252apMcgMlLBC5DrhhMq OPAFNmZltOrBOjmX2+gA== Received: from nalasppmta01.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3vhvqw0g7h-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 10 Jan 2024 17:24:12 +0000 (GMT) Received: from nalasex01b.na.qualcomm.com (nalasex01b.na.qualcomm.com [10.47.209.197]) by NALASPPMTA01.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 40AHOC31018464 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 10 Jan 2024 17:24:12 GMT Received: from [10.110.49.201] (10.80.80.8) by nalasex01b.na.qualcomm.com (10.47.209.197) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Wed, 10 Jan 2024 09:24:07 -0800 Message-ID: Date: Wed, 10 Jan 2024 09:24:07 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 1/3] check-uapi: Introduce check-uapi.sh To: Masahiro Yamada CC: Nathan Chancellor , Nick Desaulniers , Nicolas Schier , "Jonathan Corbet" , , , , , , Greg Kroah-Hartman , Rob Herring , Carlos O'Donell , Randy Dunlap , Arnd Bergmann , Bjorn Andersson , Todd Kjos , Matthias Maennich , Giuliano Procida , , , Dodji Seketeli , Trilok Soni , Satya Durga Srinivasu Prabhala , Jordan Crouse References: <20231212020259.2451253-1-quic_johmoo@quicinc.com> <20231212020259.2451253-2-quic_johmoo@quicinc.com> Content-Language: en-US From: John Moon In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01b.na.qualcomm.com (10.47.209.197) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: l5JGLIoJ9IVeazey9Op9u_gDU-7_WqWn X-Proofpoint-ORIG-GUID: l5JGLIoJ9IVeazey9Op9u_gDU-7_WqWn X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-12-09_01,2023-12-07_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 impostorscore=0 spamscore=0 lowpriorityscore=0 bulkscore=0 clxscore=1011 malwarescore=0 priorityscore=1501 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2311290000 definitions=main-2401100140 X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 12/22/2023 9:50 AM, Masahiro Yamada wrote: > On Tue, Dec 12, 2023 at 11:04 AM John Moon wrote: > > The code looks OK. I think it should work as designed. > > Line 197 is inconsistently indented by spaces instead of a space, > but I can fix it up locally. > > > I just thought requiring target commits as positional parameters > ("check-uapi.sh treeA treeB" just like "git diff treeA treeB") > might be intuitive, but I guess everything is specified > by a short option is a design. I can live with that. > > > > I will wait a few days, and if there is nothing more, > I will pick up 1/3 and 2/3. > > Thank you Masahiro! If anyone else has comments please let me know. Cheers, John