* build break in strcpy.c
@ 2014-11-24 19:46 Petar Jovanovic
2014-11-24 21:48 ` Wilco Dijkstra
0 siblings, 1 reply; 2+ messages in thread
From: Petar Jovanovic @ 2014-11-24 19:46 UTC (permalink / raw)
To: 'Wilco Dijkstra'; +Cc: libc-alpha
➢ commit b863d2bc4db728213e54ff502d2c3ae5dfa0db25
➢ Author: Wilco Dijkstra <wdijkstr@arm.com>
➢ Date: Mon Nov 24 15:09:07 2014 +0000
➢
➢ Improve strcpy performance.
Can you actually build the code after this change?
You may want to follow up with:
diff --git a/string/strcpy.c b/string/strcpy.c
index 91f9cc6..94ca1df 100644
--- a/string/strcpy.c
+++ b/string/strcpy.c
@@ -24,6 +24,6 @@
char *
strcpy (char *dest, const char *src)
{
- return memcpy (dest, src, strlen (src) + 1));
+ return memcpy (dest, src, strlen (src) + 1);
}
libc_hidden_builtin_def (strcpy)
Regards,
Petar
^ permalink raw reply [flat|nested] 2+ messages in thread
* RE: build break in strcpy.c
2014-11-24 19:46 build break in strcpy.c Petar Jovanovic
@ 2014-11-24 21:48 ` Wilco Dijkstra
0 siblings, 0 replies; 2+ messages in thread
From: Wilco Dijkstra @ 2014-11-24 21:48 UTC (permalink / raw)
To: 'Petar Jovanovic'; +Cc: libc-alpha
> Petar Jovanovic wrote:
>
> Can you actually build the code after this change?
>
> You may want to follow up with:
>
> diff --git a/string/strcpy.c b/string/strcpy.c
> index 91f9cc6..94ca1df 100644
> --- a/string/strcpy.c
> +++ b/string/strcpy.c
> @@ -24,6 +24,6 @@
> char *
> strcpy (char *dest, const char *src)
> {
> - return memcpy (dest, src, strlen (src) + 1));
> + return memcpy (dest, src, strlen (src) + 1);
> }
> libc_hidden_builtin_def (strcpy)
Sorry, not sure where that extra character came from - it seems to
be in the email with the patch but not in my original code...
Anyway, committed as obvious, and it builds again now.
Wilco
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-11-24 21:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-11-24 19:46 build break in strcpy.c Petar Jovanovic
2014-11-24 21:48 ` Wilco Dijkstra
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).