From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id 7B3403860017 for ; Thu, 25 Jun 2020 18:47:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 7B3403860017 Received: from pps.filterd (m0098404.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 05PIZRxD040529 for ; Thu, 25 Jun 2020 14:47:44 -0400 Received: from ppma04wdc.us.ibm.com (1a.90.2fa9.ip4.static.sl-reverse.com [169.47.144.26]) by mx0a-001b2d01.pphosted.com with ESMTP id 31vbmudnue-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 25 Jun 2020 14:47:44 -0400 Received: from pps.filterd (ppma04wdc.us.ibm.com [127.0.0.1]) by ppma04wdc.us.ibm.com (8.16.0.42/8.16.0.42) with SMTP id 05PIiHnN016688 for ; Thu, 25 Jun 2020 18:47:43 GMT Received: from b01cxnp23032.gho.pok.ibm.com (b01cxnp23032.gho.pok.ibm.com [9.57.198.27]) by ppma04wdc.us.ibm.com with ESMTP id 31uurye8a5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 25 Jun 2020 18:47:43 +0000 Received: from b01ledav006.gho.pok.ibm.com (b01ledav006.gho.pok.ibm.com [9.57.199.111]) by b01cxnp23032.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 05PIlhQZ38338896 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 25 Jun 2020 18:47:43 GMT Received: from b01ledav006.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id F4074AC05B; Thu, 25 Jun 2020 18:47:42 +0000 (GMT) Received: from b01ledav006.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 994C4AC059; Thu, 25 Jun 2020 18:47:40 +0000 (GMT) Received: from localhost.localdomain (unknown [9.160.120.117]) by b01ledav006.gho.pok.ibm.com (Postfix) with ESMTP; Thu, 25 Jun 2020 18:47:39 +0000 (GMT) Subject: Re: [PATCH] powerpc: Add support for POWER10 To: Tulio Magno Quites Machado Filho , libc-alpha@sourceware.org References: <20200625001020.254521-1-tuliom@linux.ibm.com> From: Matheus Castanho Message-ID: <000f9683-c6c2-a043-4afa-f2756404f6c4@linux.ibm.com> Date: Thu, 25 Jun 2020 15:47:37 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20200625001020.254521-1-tuliom@linux.ibm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.216, 18.0.687 definitions=2020-06-25_15:2020-06-25, 2020-06-25 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 malwarescore=0 bulkscore=0 impostorscore=0 suspectscore=0 adultscore=0 spamscore=0 phishscore=0 clxscore=1015 cotscore=-2147483648 mlxlogscore=999 lowpriorityscore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2004280000 definitions=main-2006250111 X-Spam-Status: No, score=-9.4 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, KAM_NUMSUBJECT, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Jun 2020 18:47:47 -0000 Hi Tulio, On 6/24/20 9:10 PM, Tulio Magno Quites Machado Filho via Libc-alpha wrote: > Add the directories to hold POWER10 files. > > Print the correct values for AT_PLATFORM and AT_BASE_PLATFORM. > --- > sysdeps/powerpc/dl-procinfo.h | 11 ++++++++++- > sysdeps/powerpc/powerpc32/power10/Implies | 2 ++ > .../powerpc/powerpc32/power10/fpu/multiarch/Implies | 1 + > sysdeps/powerpc/powerpc32/power10/multiarch/Implies | 1 + > sysdeps/powerpc/powerpc64/be/power10/Implies | 3 +++ > sysdeps/powerpc/powerpc64/be/power10/fpu/Implies | 2 ++ > .../powerpc64/be/power10/fpu/multiarch/Implies | 1 + > .../powerpc/powerpc64/be/power10/multiarch/Implies | 1 + > sysdeps/powerpc/powerpc64/le/power10/Implies | 1 + > sysdeps/powerpc/powerpc64/le/power10/fpu/Implies | 1 + > .../powerpc64/le/power10/fpu/multiarch/Implies | 1 + > .../powerpc/powerpc64/le/power10/multiarch/Implies | 1 + > 12 files changed, 25 insertions(+), 1 deletion(-) > create mode 100644 sysdeps/powerpc/powerpc32/power10/Implies > create mode 100644 sysdeps/powerpc/powerpc32/power10/fpu/multiarch/Implies > create mode 100644 sysdeps/powerpc/powerpc32/power10/multiarch/Implies > create mode 100644 sysdeps/powerpc/powerpc64/be/power10/Implies > create mode 100644 sysdeps/powerpc/powerpc64/be/power10/fpu/Implies > create mode 100644 sysdeps/powerpc/powerpc64/be/power10/fpu/multiarch/Implies > create mode 100644 sysdeps/powerpc/powerpc64/be/power10/multiarch/Implies > create mode 100644 sysdeps/powerpc/powerpc64/le/power10/Implies > create mode 100644 sysdeps/powerpc/powerpc64/le/power10/fpu/Implies > create mode 100644 sysdeps/powerpc/powerpc64/le/power10/fpu/multiarch/Implies > create mode 100644 sysdeps/powerpc/powerpc64/le/power10/multiarch/Implies > > diff --git a/sysdeps/powerpc/dl-procinfo.h b/sysdeps/powerpc/dl-procinfo.h > index 9ae85f46ec..497dc568e9 100644 > --- a/sysdeps/powerpc/dl-procinfo.h > +++ b/sysdeps/powerpc/dl-procinfo.h > @@ -37,7 +37,7 @@ > #define HWCAP_IMPORTANT (PPC_FEATURE_HAS_ALTIVEC \ > + PPC_FEATURE_HAS_DFP) > > -#define _DL_PLATFORMS_COUNT 15 > +#define _DL_PLATFORMS_COUNT 16 OK. > > #define _DL_FIRST_PLATFORM 32 > /* Mask to filter out platforms. */ > @@ -60,6 +60,7 @@ > #define PPC_PLATFORM_PPC476 12 > #define PPC_PLATFORM_POWER8 13 > #define PPC_PLATFORM_POWER9 14 > +#define PPC_PLATFORM_POWER10 15 OK. > > static inline const char * > __attribute__ ((unused)) > @@ -91,6 +92,14 @@ _dl_string_platform (const char *str) > str += 5; > switch (*str) > { > + case '1': > + if (str[1] == '0') > + { > + ret = _DL_FIRST_PLATFORM + PPC_PLATFORM_POWER10; > + } > + else > + return -1; > + break; OK. > case '4': > ret = _DL_FIRST_PLATFORM + PPC_PLATFORM_POWER4; > break; > diff --git a/sysdeps/powerpc/powerpc32/power10/Implies b/sysdeps/powerpc/powerpc32/power10/Implies > new file mode 100644 > index 0000000000..b298aca71f > --- /dev/null > +++ b/sysdeps/powerpc/powerpc32/power10/Implies > @@ -0,0 +1,2 @@ > +powerpc/powerpc32/power9/fpu > +powerpc/powerpc32/power9 > diff --git a/sysdeps/powerpc/powerpc32/power10/fpu/multiarch/Implies b/sysdeps/powerpc/powerpc32/power10/fpu/multiarch/Implies > new file mode 100644 > index 0000000000..1ffddd1cda > --- /dev/null > +++ b/sysdeps/powerpc/powerpc32/power10/fpu/multiarch/Implies > @@ -0,0 +1 @@ > +powerpc/powerpc32/power9/fpu/multiarch > diff --git a/sysdeps/powerpc/powerpc32/power10/multiarch/Implies b/sysdeps/powerpc/powerpc32/power10/multiarch/Implies > new file mode 100644 > index 0000000000..46363b5207 > --- /dev/null > +++ b/sysdeps/powerpc/powerpc32/power10/multiarch/Implies > @@ -0,0 +1 @@ > +powerpc/powerpc32/power9/multiarch > diff --git a/sysdeps/powerpc/powerpc64/be/power10/Implies b/sysdeps/powerpc/powerpc64/be/power10/Implies > new file mode 100644 > index 0000000000..2a4fe87b9e > --- /dev/null > +++ b/sysdeps/powerpc/powerpc64/be/power10/Implies > @@ -0,0 +1,3 @@ > +powerpc/powerpc64/power10 This directory does not exist. So should it or should this line be removed? > +powerpc/powerpc64/be/power9/fpu > +powerpc/powerpc64/be/power9 > diff --git a/sysdeps/powerpc/powerpc64/be/power10/fpu/Implies b/sysdeps/powerpc/powerpc64/be/power10/fpu/Implies > new file mode 100644 > index 0000000000..01e4a5a3f6 > --- /dev/null > +++ b/sysdeps/powerpc/powerpc64/be/power10/fpu/Implies > @@ -0,0 +1,2 @@ > +powerpc/powerpc64/power10/fpu The same applies here. Directory does not exist. These seem to be the only 'Implied' ones missing. With your patch applied to the tree: [sysdeps]$ git diff HEAD^ | for d in $(grep '+powerpc'); do d=${d:1}; [ -d $d ] && echo "OK!" || echo "Not found -> $d"; done OK! OK! OK! OK! Not found -> powerpc/powerpc64/power10 OK! OK! Not found -> powerpc/powerpc64/power10/fpu OK! OK! OK! OK! OK! OK! OK! > +powerpc/powerpc64/be/power9/fpu > diff --git a/sysdeps/powerpc/powerpc64/be/power10/fpu/multiarch/Implies b/sysdeps/powerpc/powerpc64/be/power10/fpu/multiarch/Implies > new file mode 100644 > index 0000000000..a336feb55b > --- /dev/null > +++ b/sysdeps/powerpc/powerpc64/be/power10/fpu/multiarch/Implies > @@ -0,0 +1 @@ > +powerpc/powerpc64/be/power9/fpu/multiarch > diff --git a/sysdeps/powerpc/powerpc64/be/power10/multiarch/Implies b/sysdeps/powerpc/powerpc64/be/power10/multiarch/Implies > new file mode 100644 > index 0000000000..b4c0f0a58a > --- /dev/null > +++ b/sysdeps/powerpc/powerpc64/be/power10/multiarch/Implies > @@ -0,0 +1 @@ > +powerpc/powerpc64/be/power9/multiarch > diff --git a/sysdeps/powerpc/powerpc64/le/power10/Implies b/sysdeps/powerpc/powerpc64/le/power10/Implies > new file mode 100644 > index 0000000000..37f19d3553 > --- /dev/null > +++ b/sysdeps/powerpc/powerpc64/le/power10/Implies > @@ -0,0 +1 @@ > +powerpc/powerpc64/le/power9 For BE you also add [...]/be/power9/fpu. Should this also be the case here for LE? > diff --git a/sysdeps/powerpc/powerpc64/le/power10/fpu/Implies b/sysdeps/powerpc/powerpc64/le/power10/fpu/Implies > new file mode 100644 > index 0000000000..1b3525a0d7 > --- /dev/null > +++ b/sysdeps/powerpc/powerpc64/le/power10/fpu/Implies > @@ -0,0 +1 @@ > +powerpc/powerpc64/le/power9/fpu > diff --git a/sysdeps/powerpc/powerpc64/le/power10/fpu/multiarch/Implies b/sysdeps/powerpc/powerpc64/le/power10/fpu/multiarch/Implies > new file mode 100644 > index 0000000000..189beb801d > --- /dev/null > +++ b/sysdeps/powerpc/powerpc64/le/power10/fpu/multiarch/Implies > @@ -0,0 +1 @@ > +powerpc/powerpc64/le/power9/fpu/multiarch > diff --git a/sysdeps/powerpc/powerpc64/le/power10/multiarch/Implies b/sysdeps/powerpc/powerpc64/le/power10/multiarch/Implies > new file mode 100644 > index 0000000000..e6e5fc887e > --- /dev/null > +++ b/sysdeps/powerpc/powerpc64/le/power10/multiarch/Implies > @@ -0,0 +1 @@ > +powerpc/powerpc64/le/power9/multiarch > -- Matheus Castanho