From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oa1-x2c.google.com (mail-oa1-x2c.google.com [IPv6:2001:4860:4864:20::2c]) by sourceware.org (Postfix) with ESMTPS id 393A9385B520 for ; Thu, 16 Mar 2023 19:45:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 393A9385B520 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-oa1-x2c.google.com with SMTP id 586e51a60fabf-17aceccdcf6so3362814fac.9 for ; Thu, 16 Mar 2023 12:45:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678995907; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=LgG0A76NG4ByCWuHuZYi+ptJJBLNadtRFH8JRaXsYGs=; b=bL6f8S4WbF4xP3ESFSXdMTvfvRxAxlkxBU3ceiMtw9CUsjocjVjZYjlMTnBDXfCm7K 9sFTPjV9ljiBaLpsiwwF64LAcKbmokhZjx09W32/CgySU1Rf1bcj50gmfzrNkUeJmQNL skxTyv9X0NqKVyfXRu/JJoty3zQNA7pbaQ29V/FWlPxp4PZLmbR1HIlyDdTbsoCbfQ5T 90WXdYDDsiEqyXu8PmUBICud4ietC3FqlbrIPAdouBhMRZhT096Z+iXOPdTryNDrJhZh UwxynxuU85fKWQnexpReGWcsyAQdkDzPRThU30/EPG87YUQ2L3nvWqbf4NFG0qTSB1BZ Q7RQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678995907; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=LgG0A76NG4ByCWuHuZYi+ptJJBLNadtRFH8JRaXsYGs=; b=bgxd0IZ/LOwRe4qmkXYPfLZ/o5elOQDcz7qzzjvmduyTPGN7VDpaf3nVRkvqSorat+ IGLgLjFzT61NkDRRd6dF6LxPkCvrJeaucHXEgv25LcUaLqVEwBMZki4BrBkmdjGX14Om UPh63bQhcUaZetleM/EBGjW1WJdAPjjxACA4zdpqsdCITOAzOK59pbRrP6cqpcgYpSKU xcJqbpaWNifuMBGRD/p5pp/nYfrFr8taTrbzVr7pUTk3Q+HzI5HBJfTzSKWX11AXdZz+ qP+aoIAAOWmfUniu7Mn9owxdWFxeEqBMq0OPiSLSJF2PITysr/RvX0ujZgeQNnhYogMh BO7A== X-Gm-Message-State: AO0yUKUbSnxuvgAMhyyOEl+WA8S8FLkcs4W5aDxfbqgGEr61HgQLm1f8 glqycZPInL6JZa8d0nVQWbgPGQ== X-Google-Smtp-Source: AK7set/iQB1bmtB1NzAdzHy6oinzXatefD3dVf0LLdk2K2hHPLoazzNkLTX+yatU/+gk2rgVmY8Tpg== X-Received: by 2002:a05:6870:b154:b0:177:cb83:4c66 with SMTP id a20-20020a056870b15400b00177cb834c66mr8700671oal.8.1678995907483; Thu, 16 Mar 2023 12:45:07 -0700 (PDT) Received: from ?IPV6:2804:1b3:a7c0:c260:9a4:3847:50c3:a2f0? ([2804:1b3:a7c0:c260:9a4:3847:50c3:a2f0]) by smtp.gmail.com with ESMTPSA id vh22-20020a0568710d1600b00177c21c3ae1sm152520oab.54.2023.03.16.12.45.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Mar 2023 12:45:06 -0700 (PDT) Message-ID: <006cd931-8077-c271-812e-5ff22758256a@linaro.org> Date: Thu, 16 Mar 2023 16:45:03 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v2 4/5] math: Improve fmodf Content-Language: en-US To: Wilco Dijkstra , "libc-alpha@sourceware.org" , "H . J . Lu" Cc: kirill References: <20230315205910.4120377-1-adhemerval.zanella@linaro.org> <20230315205910.4120377-5-adhemerval.zanella@linaro.org> <3d3ff2cd-2187-8b54-cb4d-bbf6d9c7ed88@linaro.org> From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 16/03/23 16:15, Wilco Dijkstra wrote: > Hi Adhemerval, > >>> So we do need to handle zero case here, I think fmodf (5, 1) will now >>> return 0.5... We could add support in make_float (see below). >> >> Ok, although at least for fmodf (5, 1) current algorithm does return 0. > > Try printing with %a, on AArch64 it shows 0x1p-25 (ie. 0.5 * 1p-24 from > passing ey-1 to make_float and CLZ (0) - 8 == 32 - 8). > > Again odd no testcase caught it... Indeed, I will also add a testcase for this.