From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-x733.google.com (mail-qk1-x733.google.com [IPv6:2607:f8b0:4864:20::733]) by sourceware.org (Postfix) with ESMTPS id 5FE463AAA080 for ; Thu, 24 Jun 2021 11:32:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5FE463AAA080 Received: by mail-qk1-x733.google.com with SMTP id g4so13609044qkl.1 for ; Thu, 24 Jun 2021 04:32:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=vainMSIYYmw7n/Fuf8TSqi45jmfZXaIAe26UD8isK/Q=; b=ujXTpTwRj6lFqCKjQjh3uvXPHnJNKJJcrfTFuh3InsNZhmDXNTn/oNrH4HJGCaJiam VGuJI0+eaW9GYJ2OOb00P+r16RagNTBPKb94w7RRM9y2M18gNZWboSWBVpbGRryrowOn D7iqSQ5hRDs12C0PWFU3f+/4xWichudNB/ZCBpUtWMar5ocmUJnm2J0ew8o7ijeQPYzI /Xmxa2xJ9/JKhASdo6cFhdhnZ9qTAqWTD3KJCYBXLl6r+qNcOWhduZ+NNVNotxDNT2D7 nAyDU1E3U3uROqC5dozuuaa0eK/7moQ5Nt0Ls8+Id3On6ntIVkNI0EKqmWibT/E3Ta+7 J7OA== X-Gm-Message-State: AOAM532SSpo6iKldFmZMfPlVy1ck724brctElDFsbqetB/g8lwx/3J0G jc3V69UZPHqZ0L+THkICfhfU+SHZmaAJ2A== X-Google-Smtp-Source: ABdhPJy+Lu8+bOoNKn6UKXmFbK1ESIPSaFu7fAxoeJMuIyYb1dNYQyc5LzLaMbofKxpTesYMPHjSSw== X-Received: by 2002:a05:620a:91a:: with SMTP id v26mr5150914qkv.297.1624534370917; Thu, 24 Jun 2021 04:32:50 -0700 (PDT) Received: from [192.168.1.108] ([177.194.59.218]) by smtp.gmail.com with ESMTPSA id y10sm1635430qta.35.2021.06.24.04.32.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 24 Jun 2021 04:32:50 -0700 (PDT) Subject: Re: [PATCH v4 1/4] posix: Consolidate fork implementation To: Florian Weimer , Adhemerval Zanella via Libc-alpha References: <20210623184354.395316-1-adhemerval.zanella@linaro.org> <20210623184354.395316-2-adhemerval.zanella@linaro.org> <87bl7vn0ee.fsf@oldenburg.str.redhat.com> From: Adhemerval Zanella Message-ID: <00cbba62-71d2-070e-79b7-cdfec22f69fe@linaro.org> Date: Thu, 24 Jun 2021 08:32:48 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <87bl7vn0ee.fsf@oldenburg.str.redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Jun 2021 11:32:52 -0000 On 24/06/2021 05:15, Florian Weimer wrote: > * Adhemerval Zanella via Libc-alpha: > >> diff --git a/include/unistd.h b/include/unistd.h >> index 34872d8b41..d554d44edb 100644 >> --- a/include/unistd.h >> +++ b/include/unistd.h >> @@ -140,6 +140,10 @@ extern __pid_t __vfork (void); >> libc_hidden_proto (__vfork) >> extern int __ttyname_r (int __fd, char *__buf, size_t __buflen); >> libc_hidden_proto (__ttyname_r) >> +extern int __ttyname_r (int __fd, char *__buf, size_t __buflen) >> + attribute_hidden; > > Duplicate declaration of __ttyname_r. Merge error? > > Rest looks okay to me. Yes, I will fix it.