public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>
To: Richard Henderson <richard.henderson@linaro.org>,
	Jeff Law <jeffreyalaw@gmail.com>,
	libc-alpha@sourceware.org
Subject: Re: [PATCH v10 00/24] Improve generic string routines
Date: Mon, 30 Jan 2023 10:26:18 -0300	[thread overview]
Message-ID: <00f4ac0a-0c0f-78c3-0d9b-7092d5f8fea5@linaro.org> (raw)
In-Reply-To: <77f4a99a-f7ba-9e84-6ef5-cae4cf874707@linaro.org>



On 27/01/23 16:36, Richard Henderson via Libc-alpha wrote:
> On 1/20/23 13:00, Jeff Law via Libc-alpha wrote:
>> You guys are making work for me! :)
>>
>> We've got hand-written RISC-V implementations of various str* and mem* routines that I nearly asked to get merged for glibc-2.37.  I held off thinking that there wasn't much benefit to including it in 2.37 vs 2.38.  Bad call on my part!
> 
> In that you'll want to benchmark your hand-written code vs the new generic code with a string-fza.h file for riscv-zbb (orc.b) or xtheadbb (th.tstnbz)?
> 
> After the benchmarking, I'm hoping you'll find that some of the hand-written code is no longer needed, and therefore won't accrue a maintenance burden going forward.
> 
> 
> r~

I think for riscv it might be advantageous to reimplement string-fzi.h
as well to check bits directly instead of using __builtin_c{t,l}z 
(similar to hppa).

  reply	other threads:[~2023-01-30 13:26 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-20 21:15 Adhemerval Zanella
2023-01-20 21:15 ` [PATCH v10 01/24] Parameterize op_t from memcopy.h Adhemerval Zanella
2023-01-20 21:16 ` [PATCH v10 02/24] Parameterize OP_T_THRES " Adhemerval Zanella
2023-01-20 21:16 ` [PATCH v10 03/24] Add string vectorized find and detection functions Adhemerval Zanella
2023-01-20 21:16 ` [PATCH v10 04/24] string: Improve generic strlen Adhemerval Zanella
2023-01-20 21:16 ` [PATCH v10 05/24] string: Improve generic strnlen Adhemerval Zanella
2023-01-20 21:16 ` [PATCH v10 06/24] string: Improve generic strchr Adhemerval Zanella
2023-01-20 21:16 ` [PATCH v10 07/24] string: Improve generic strchrnul Adhemerval Zanella
2023-01-20 21:16 ` [PATCH v10 08/24] string: Improve generic strcmp Adhemerval Zanella
2023-01-20 21:16 ` [PATCH v10 09/24] string: Improve generic strncmp Adhemerval Zanella
2023-01-20 21:16 ` [PATCH v10 10/24] string: Improve generic memchr Adhemerval Zanella
2023-01-20 21:16 ` [PATCH v10 11/24] string: Improve generic memrchr Adhemerval Zanella
2023-01-20 21:16 ` [PATCH v10 12/24] hppa: Add memcopy.h Adhemerval Zanella
2023-01-20 21:16 ` [PATCH v10 13/24] hppa: Add string-fzb.h and string-fzi.h Adhemerval Zanella
2023-01-20 21:16 ` [PATCH v10 14/24] alpha: " Adhemerval Zanella
2023-01-20 21:16 ` [PATCH v10 15/24] arm: Add string-fza.h Adhemerval Zanella
2023-01-20 21:16 ` [PATCH v10 16/24] powerpc: " Adhemerval Zanella
2023-01-20 21:16 ` [PATCH v10 17/24] sh: Add string-fzb.h Adhemerval Zanella
2023-01-20 21:16 ` [PATCH v10 18/24] string: Hook up the default implementation on test-strlen Adhemerval Zanella
2023-01-20 21:16 ` [PATCH v10 19/24] string: Hook up the default implementation on test-strnlen Adhemerval Zanella
2023-01-20 21:16 ` [PATCH v10 20/24] string: Hook up the default implementation on test-strchr Adhemerval Zanella
2023-01-20 21:16 ` [PATCH v10 21/24] string: Hook up the default implementation on test-strcmp Adhemerval Zanella
2023-01-20 21:16 ` [PATCH v10 22/24] string: Hook up the default implementation on test-strncmp Adhemerval Zanella
2023-01-20 21:16 ` [PATCH v10 23/24] string: Hook up the default implementation on test-memchr Adhemerval Zanella
2023-01-20 21:16 ` [PATCH v10 24/24] string: Hook up the default implementation on test-memrchr Adhemerval Zanella
2023-01-20 23:00 ` [PATCH v10 00/24] Improve generic string routines Jeff Law
2023-01-27 16:52   ` Adhemerval Zanella Netto
2023-01-27 19:36   ` Richard Henderson
2023-01-30 13:26     ` Adhemerval Zanella Netto [this message]
2023-01-30 18:37       ` Jeff Law
2023-01-28 14:30 ` Xi Ruoyao
2023-01-30 13:10   ` Adhemerval Zanella Netto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=00f4ac0a-0c0f-78c3-0d9b-7092d5f8fea5@linaro.org \
    --to=adhemerval.zanella@linaro.org \
    --cc=jeffreyalaw@gmail.com \
    --cc=libc-alpha@sourceware.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).